[Lldb-commits] [lldb] r182166 - The Linux process plugin wasn't returning the correct linux signals. This fixes that.
Matt Kopec
Matt.Kopec at intel.com
Fri May 17 15:21:08 PDT 2013
Author: mkopec
Date: Fri May 17 17:21:08 2013
New Revision: 182166
URL: http://llvm.org/viewvc/llvm-project?rev=182166&view=rev
Log:
The Linux process plugin wasn't returning the correct linux signals. This fixes that.
Thus, this patch also negates a previous fix for handling SIGCHLD.
Modified:
lldb/trunk/source/Plugins/Process/Linux/ProcessLinux.h
lldb/trunk/source/Plugins/Process/Linux/ProcessMonitor.cpp
Modified: lldb/trunk/source/Plugins/Process/Linux/ProcessLinux.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Linux/ProcessLinux.h?rev=182166&r1=182165&r2=182166&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/Linux/ProcessLinux.h (original)
+++ lldb/trunk/source/Plugins/Process/Linux/ProcessLinux.h Fri May 17 17:21:08 2013
@@ -75,6 +75,15 @@ public:
EnablePluginLogging(lldb_private::Stream *strm,
lldb_private::Args &command);
+ //------------------------------------------------------------------
+ // Plug-in process overrides
+ //------------------------------------------------------------------
+ virtual lldb_private::UnixSignals &
+ GetUnixSignals ()
+ {
+ return m_linux_signals;
+ }
+
private:
/// Linux-specific signal set.
Modified: lldb/trunk/source/Plugins/Process/Linux/ProcessMonitor.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Linux/ProcessMonitor.cpp?rev=182166&r1=182165&r2=182166&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/Linux/ProcessMonitor.cpp (original)
+++ lldb/trunk/source/Plugins/Process/Linux/ProcessMonitor.cpp Fri May 17 17:21:08 2013
@@ -1492,17 +1492,6 @@ ProcessMonitor::MonitorSignal(ProcessMon
return ProcessMessage::Crash(pid, reason, signo, fault_addr);
}
- if (signo == SIGCHLD) {
- assert(monitor);
- // TODO: Implement tracing of inferiors' children
- // If we fail to deliver the signal then create a message with the signal
- if (!monitor->Resume(pid, signo)) {
- assert(0 && "SIGCHLD delivery failed");
- message = ProcessMessage::Signal(pid, signo);
- }
- return message;
- }
-
// Everything else is "normal" and does not require any special action on
// our part.
return ProcessMessage::Signal(pid, signo);
More information about the lldb-commits
mailing list