[Lldb-commits] [lldb] r182069 - Comment out ObjectFileELF::GetModuleSpecifications() function until I can debug where it's causing tests to fail.

[Greg Clayton]

We need to make sure that the target triple that is used for expressions didn't change when this function was implemented. 

When evaluating expressions, we create a new clang::ASTContext using the lldb_private::Target's architecture target triple. If this triple changed after ObjectFileELF::GetModuleSpecifications
() was filled in, it could explain the failures. 

We need to make sure that the target triple for a linux executable is the same as clang would normally use when compiling a source file on a linux host so that we create the correct conditions for expressions. I may turn out that we were returning the wrong triple, or it may turn out the triple is correct and we need to deal with the expression parser fallout by fixing bugs now that the triple is correct.

Let me know what you find.

Greg Clayton


On May 16, 2013, at 7:00 PM, Michael Sartain <mikesart at valvesoftware.com> wrote:

> Author: mikesart
> Date: Thu May 16 21:00:55 2013
> New Revision: 182069
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=182069&view=rev
> Log:
> Comment out ObjectFileELF::GetModuleSpecifications() function until I can debug where it's causing tests to fail.
> 
> Modified:
>    lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
> 
> Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp?rev=182069&r1=182068&r2=182069&view=diff
> ==============================================================================
> --- lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp (original)
> +++ lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp Thu May 16 21:00:55 2013
> @@ -243,8 +243,11 @@ ObjectFileELF::GetModuleSpecifications (
>                                         lldb::offset_t length,
>                                         lldb_private::ModuleSpecList &specs)
> {
> +// FIXME: mikesart at valvesoftware.com
> +// Implementing this function has broken several tests. Specifically this one:
> +// Python dotest.py --executable <path-to-lldb> -p TestCallStdStringFunction.py
>     const size_t initial_count = specs.GetSize();
> -    
> +#if 0    
>     if (ObjectFileELF::MagicBytesMatch(data_sp, 0, data_sp->GetByteSize()))
>     {
>         DataExtractor data;
> @@ -269,6 +272,7 @@ ObjectFileELF::GetModuleSpecifications (
>             }
>         }
>     }
> +#endif
>     return specs.GetSize() - initial_count;
> }
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits