[Lldb-commits] [lldb] r180870 - Revert 180829 as it causes hangs in TestTypeCompletion.py on 2 Linux buildbots:

Daniel Malea daniel.malea at intel.com
Wed May 1 12:14:30 PDT 2013


Author: dmalea
Date: Wed May  1 14:14:30 2013
New Revision: 180870

URL: http://llvm.org/viewvc/llvm-project?rev=180870&view=rev
Log:
Revert 180829 as it causes hangs in TestTypeCompletion.py on 2 Linux buildbots:

http://lab.llvm.org:8011/builders/lldb-x86_64-linux/builds/3810
http://lab.llvm.org:8011/builders/lldb-x86_64-debian-clang/builds/2754


Modified:
    lldb/trunk/include/lldb/Target/ThreadPlanBase.h
    lldb/trunk/source/Target/ThreadPlanBase.cpp

Modified: lldb/trunk/include/lldb/Target/ThreadPlanBase.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Target/ThreadPlanBase.h?rev=180870&r1=180869&r2=180870&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Target/ThreadPlanBase.h (original)
+++ lldb/trunk/include/lldb/Target/ThreadPlanBase.h Wed May  1 14:14:30 2013
@@ -37,7 +37,6 @@ public:
     virtual bool ValidatePlan (Stream *error);
     virtual bool PlanExplainsStop (Event *event_ptr);
     virtual bool ShouldStop (Event *event_ptr);
-    virtual Vote ShouldReportStop (Event *event_ptr);
     virtual bool StopOthers ();
     virtual lldb::StateType GetPlanRunState ();
     virtual bool WillStop ();

Modified: lldb/trunk/source/Target/ThreadPlanBase.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanBase.cpp?rev=180870&r1=180869&r2=180870&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanBase.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanBase.cpp Wed May  1 14:14:30 2013
@@ -78,22 +78,6 @@ ThreadPlanBase::PlanExplainsStop (Event
         return true;
 }
 
-Vote
-ThreadPlanBase::ShouldReportStop(Event *event_ptr)
-{
-    StopInfoSP stop_info_sp = GetPrivateStopReason();
-    if (stop_info_sp)
-    {
-        bool should_notify = stop_info_sp->ShouldNotify(event_ptr);
-        if (should_notify)
-            return eVoteYes;
-        else
-            return eVoteNoOpinion;
-    }
-    else
-        return eVoteNoOpinion;
-}
-
 bool
 ThreadPlanBase::ShouldStop (Event *event_ptr)
 {





More information about the lldb-commits mailing list