[Lldb-commits] [lldb] r180706 - When lldb stops in a stack frame where we have source level information (file, line number), don't

Jason Molenda jmolenda at apple.com
Mon Apr 29 02:59:31 PDT 2013


Author: jmolenda
Date: Mon Apr 29 04:59:31 2013
New Revision: 180706

URL: http://llvm.org/viewvc/llvm-project?rev=180706&view=rev
Log:
When lldb stops in a stack frame where we have source level information (file, line number), don't
print the disassembly context around $pc -- just print the filename and line number, even if we 
can't show the source code.  Previously if the source file was not available, lldb would print
the source filename & line number and assembly.  
<rdar://problem/13072951> 

Modified:
    lldb/trunk/source/Target/StackFrame.cpp

Modified: lldb/trunk/source/Target/StackFrame.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StackFrame.cpp?rev=180706&r1=180705&r2=180706&view=diff
==============================================================================
--- lldb/trunk/source/Target/StackFrame.cpp (original)
+++ lldb/trunk/source/Target/StackFrame.cpp Mon Apr 29 04:59:31 2013
@@ -1399,15 +1399,13 @@ StackFrame::GetStatus (Stream& strm,
 
                 if (m_sc.comp_unit && m_sc.line_entry.IsValid())
                 {
-                    if (target->GetSourceManager().DisplaySourceLinesWithLineNumbers (m_sc.line_entry.file,
+                    have_source = true;
+                    target->GetSourceManager().DisplaySourceLinesWithLineNumbers (m_sc.line_entry.file,
                                                                                       m_sc.line_entry.line,
                                                                                       source_lines_before,
                                                                                       source_lines_after,
                                                                                       "->",
-                                                                                      &strm))
-                    {
-                        have_source = true;
-                    }
+                                                                                      &strm);
                 }
             }
             switch (disasm_display)





More information about the lldb-commits mailing list