[Lldb-commits] REVIEW: Compile and sign debugserver binary using the Makefiles

[Filipe Cabecinhas]

Hi Charles,

Sorry for the delay, but I only got to see your patches today. You
only included patches for llvm's Makefile.rules, and one for
lldb.xcodeproj.
The xcodeproj may be changing stuff that Apple people wish to keep as
it is, and is unrelated to the Makefiles, so I suppose a separate
patch submitted to lldb-commits would be better.

The other patches are only for llvm's Makefile.rules (unless I (or
you, when attaching files to the email) missed something) and use
stuff that I don't know about Makefiles. You should submit them to
llvm-commits and ask Eric Cristopher (the code owner for the
autotools-based build system) to review them.

I will submit my changes, since yours don't add to them and, if yours
get committed to llvm's Makefile.rules, we can then change our
Makefiles, if there's improvements to make.

Regards,

  Filipe

  F


On Mon, Apr 8, 2013 at 10:20 PM, Charles Davis <cdavis5x at gmail.com> wrote:
>
> On Apr 5, 2013, at 1:38 PM, Filipe Cabecinhas wrote:
>> Please send me the patches, then. I will incorporate before committing.
> As ye requested.
>
> The first three are patches to LLVM--specifically to the Makefile system. The first one of those adds support for custom code-signing identities and entitlements. The third adds support for assembler source to the build system. The second is only really needed because the third expects it to be there--if you want, I can rewrite and reorder these in my local Git repository so that the assembler-source patch comes earlier.
>
> The last patch is the actual patch that adds debugserver to the build system. In its current form, it needs all three of those LLVM makefile patches applied first--in fact, I wrote the second one so I could actually build the debugserver without adding a bunch of (what I thought at the time were superfluous) makefiles to the subdirectories. It did make the debugserver Makefile really big and complicated, though. (The second patch also allowed me to simplify the Host/MacOSX makefile, but that's for another day.) Your debugserver patch doesn't need that patch, though; I expect that you'll just end up cannibalizing some portions of my patches to put into yours.
>
> Chip