[Lldb-commits] [lldb] r179822 - Remove an unneeded local var, a missing return statement in kernel search code, thanks to Greg Clayton for finding these.

Jason Molenda jmolenda at apple.com
Thu Apr 18 17:50:28 PDT 2013


Author: jmolenda
Date: Thu Apr 18 19:50:28 2013
New Revision: 179822

URL: http://llvm.org/viewvc/llvm-project?rev=179822&view=rev
Log:
Remove an unneeded local var, a missing return statement in kernel search code, thanks to Greg Clayton for finding these.

Modified:
    lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp

Modified: lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp?rev=179822&r1=179821&r2=179822&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp (original)
+++ lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp Thu Apr 18 19:50:28 2013
@@ -294,21 +294,19 @@ DynamicLoaderDarwinKernel::SearchForKern
     if (pc == LLDB_INVALID_ADDRESS)
         return LLDB_INVALID_ADDRESS;
 
-    addr_t kernel_range_low, kernel_range_high;
+    addr_t kernel_range_low;
     if (process->GetTarget().GetArchitecture().GetAddressByteSize() == 8)
     {
         kernel_range_low = 1ULL << 63;
-        kernel_range_high = UINT64_MAX;
     }
     else
     {
         kernel_range_low = 1ULL << 31;
-        kernel_range_high = UINT32_MAX;
     }
 
     // Outside the normal kernel address range, this is probably userland code running right now
     if (pc < kernel_range_low)
-        LLDB_INVALID_ADDRESS;
+        return LLDB_INVALID_ADDRESS;
 
     // The kernel will load at at one megabyte boundary (0x100000), or at that boundary plus 
     // an offset of one page (0x1000) or two, depending on the device.





More information about the lldb-commits mailing list