[Lldb-commits] [lldb] r179561 - Fixed a few bugs in IRMemoryMap:

[Sean Callanan]

Author: spyffe
Date: Mon Apr 15 16:35:52 2013
New Revision: 179561

URL: http://llvm.org/viewvc/llvm-project?rev=179561&view=rev
Log:
Fixed a few bugs in IRMemoryMap:

- If an allocation is mirrored between the host
  and the process, update the host's version
  before returning a DataExtractor pointing to
  it.

- If anyone attempts to access memory in a
  process/target that does not have a corresponding
  allocation, try accessing the memory directly
  before erroring out.

Modified:
    lldb/trunk/source/Expression/IRMemoryMap.cpp

Modified: lldb/trunk/source/Expression/IRMemoryMap.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/IRMemoryMap.cpp?rev=179561&r1=179560&r2=179561&view=diff
==============================================================================
--- lldb/trunk/source/Expression/IRMemoryMap.cpp (original)
+++ lldb/trunk/source/Expression/IRMemoryMap.cpp Mon Apr 15 16:35:52 2013
@@ -325,8 +325,16 @@ IRMemoryMap::WriteMemory (lldb::addr_t p
     
     if (iter == m_allocations.end())
     {
+        lldb::ProcessSP process_sp = m_process_wp.lock();
+        
+        if (process_sp)
+        {
+            process_sp->WriteMemory(process_address, bytes, size, error);
+            return;
+        }
+        
         error.SetErrorToGenericError();
-        error.SetErrorString("Couldn't write: no allocation contains the target range");
+        error.SetErrorString("Couldn't write: no allocation contains the target range and the process doesn't exist");
         return;
     }
     
@@ -433,8 +441,25 @@ IRMemoryMap::ReadMemory (uint8_t *bytes,
     
     if (iter == m_allocations.end())
     {
+        lldb::ProcessSP process_sp = m_process_wp.lock();
+        
+        if (process_sp)
+        {
+            process_sp->ReadMemory(process_address, bytes, size, error);
+            return;
+        }
+        
+        lldb::TargetSP target_sp = m_target_wp.lock();
+        
+        if (target_sp)
+        {
+            Address absolute_address(process_address);
+            target_sp->ReadMemory(absolute_address, false, bytes, size, error);
+            return;
+        }
+        
         error.SetErrorToGenericError();
-        error.SetErrorString("Couldn't read: no allocation contains the target range");
+        error.SetErrorString("Couldn't read: no allocation contains the target range, and neither the process nor the target exist");
         return;
     }
     
@@ -561,8 +586,27 @@ IRMemoryMap::GetMemoryData (DataExtracto
             error.SetErrorToGenericError();
             error.SetErrorString("Couldn't get memory data: memory is only in the target");
             return;
-        case eAllocationPolicyHostOnly:
         case eAllocationPolicyMirror:
+            {
+                lldb::ProcessSP process_sp = m_process_wp.lock();
+
+                if (!allocation.m_data.get())
+                {
+                    error.SetErrorToGenericError();
+                    error.SetErrorString("Couldn't get memory data: data buffer is empty");
+                    return;
+                }
+                if (process_sp)
+                {
+                    process_sp->ReadMemory(allocation.m_process_start, allocation.m_data->GetBytes(), allocation.m_data->GetByteSize(), error);
+                    if (!error.Success())
+                        return;
+                    uint64_t offset = process_address - allocation.m_process_start;
+                    extractor = DataExtractor(allocation.m_data->GetBytes() + offset, size, GetByteOrder(), GetAddressByteSize());
+                    return;
+                }
+            }
+        case eAllocationPolicyHostOnly:
             if (!allocation.m_data.get())
             {
                 error.SetErrorToGenericError();