[Lldb-commits] REVIEW: Compile and sign debugserver binary using the Makefiles

[Charles Davis]

On Apr 5, 2013, at 1:38 PM, Filipe Cabecinhas wrote:
> Please send me the patches, then. I will incorporate before committing.
As ye requested.

The first three are patches to LLVM--specifically to the Makefile system. The first one of those adds support for custom code-signing identities and entitlements. The third adds support for assembler source to the build system. The second is only really needed because the third expects it to be there--if you want, I can rewrite and reorder these in my local Git repository so that the assembler-source patch comes earlier.

The last patch is the actual patch that adds debugserver to the build system. In its current form, it needs all three of those LLVM makefile patches applied first--in fact, I wrote the second one so I could actually build the debugserver without adding a bunch of (what I thought at the time were superfluous) makefiles to the subdirectories. It did make the debugserver Makefile really big and complicated, though. (The second patch also allowed me to simplify the Host/MacOSX makefile, but that's for another day.) Your debugserver patch doesn't need that patch, though; I expect that you'll just end up cannibalizing some portions of my patches to put into yours.

Chip
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Makefiles-Allow-tools-that-want-to-be-codesigned-to-.patch
Type: application/octet-stream
Size: 1704 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130408/e6af964e/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Makefiles-Make-sure-sources-in-subdirectories-compil.patch
Type: application/octet-stream
Size: 10841 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130408/e6af964e/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Makefiles-Add-support-for-assembler-source-files.patch
Type: application/octet-stream
Size: 2798 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130408/e6af964e/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-debugserver-Some-additions-to-the-build-settings-for.patch
Type: application/octet-stream
Size: 3769 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130408/e6af964e/attachment-0003.obj>