[Lldb-commits] [lldb] r177810 - Invert two condition checks to evaluate them in cheapest-to-more-expensive order

Enrico Granata egranata at apple.com
Fri Mar 22 18:44:23 PDT 2013


Author: enrico
Date: Fri Mar 22 20:44:23 2013
New Revision: 177810

URL: http://llvm.org/viewvc/llvm-project?rev=177810&view=rev
Log:
Invert two condition checks to evaluate them in cheapest-to-more-expensive order

Modified:
    lldb/trunk/source/Core/ValueObject.cpp

Modified: lldb/trunk/source/Core/ValueObject.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObject.cpp?rev=177810&r1=177809&r2=177810&view=diff
==============================================================================
--- lldb/trunk/source/Core/ValueObject.cpp (original)
+++ lldb/trunk/source/Core/ValueObject.cpp Fri Mar 22 20:44:23 2013
@@ -1259,9 +1259,9 @@ ValueObject::GetValueAsCString (lldb::Fo
                     lldb_private::DataExtractor special_format_data;
                     clang::ASTContext* ast = GetClangAST();
                     Flags type_flags(ClangASTContext::GetTypeInfo(clang_type, ast, NULL));
-                    if (type_flags.Test(ClangASTContext::eTypeIsPointer) && !type_flags.Test(ClangASTContext::eTypeIsObjC))
+                    if (format == eFormatCString)
                     {
-                        if (format == eFormatCString)
+                        if (type_flags.Test(ClangASTContext::eTypeIsPointer) && !type_flags.Test(ClangASTContext::eTypeIsObjC))
                         {
                             // if we are dumping a pointer as a c-string, get the pointee data as a string
                             TargetSP target_sp(GetTargetSP());





More information about the lldb-commits mailing list