[Lldb-commits] [lldb] r177688 - Don't try to read the eh_frame section out of a dSYM.

[Jason Molenda]

Author: jmolenda
Date: Thu Mar 21 19:38:45 2013
New Revision: 177688

URL: http://llvm.org/viewvc/llvm-project?rev=177688&view=rev
Log:
Don't try to read the eh_frame section out of a dSYM.
It won't have one and it isn't needed.

Modified:
    lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

Modified: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp?rev=177688&r1=177687&r2=177688&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp Thu Mar 21 19:38:45 2013
@@ -1477,7 +1477,11 @@ ObjectFileMachO::ParseSymtab (bool minim
         } 
         else
         {
-            if (text_section_sp.get() && eh_frame_section_sp.get())
+            // If m_type is eTypeDebugInfo, then this is a dSYM - it will have the load command claiming an eh_frame
+            // but it doesn't actually have the eh_frame content.  And if we have a dSYM, we don't need to do any
+            // of this fill-in-the-missing-symbols works anyway - the debug info should give us all the functions in
+            // the module.
+            if (text_section_sp.get() && eh_frame_section_sp.get() && m_type != eTypeDebugInfo)
             {
                 DWARFCallFrameInfo eh_frame(*this, eh_frame_section_sp, eRegisterKindGCC, true);
                 DWARFCallFrameInfo::FunctionAddressAndSizeVector functions;