[Lldb-commits] [lldb] r176203 - Call Process::Finalize directly in Debugger::Destroy, rather than having it done

[Jim Ingham]

Author: jingham
Date: Wed Feb 27 13:13:05 2013
New Revision: 176203

URL: http://llvm.org/viewvc/llvm-project?rev=176203&view=rev
Log:
Call Process::Finalize directly in Debugger::Destroy, rather than having it done 
in the Process destructor.  Doing it there can be too late depending on what the internal state
and ProcessGDBRemote Async threads are doing.

<rdar://problem/13297536>

Modified:
    lldb/trunk/source/Core/Debugger.cpp

Modified: lldb/trunk/source/Core/Debugger.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/Debugger.cpp?rev=176203&r1=176202&r2=176203&view=diff
==============================================================================
--- lldb/trunk/source/Core/Debugger.cpp (original)
+++ lldb/trunk/source/Core/Debugger.cpp Wed Feb 27 13:13:05 2013
@@ -607,10 +607,7 @@ Debugger::Clear()
         {
             ProcessSP process_sp (target_sp->GetProcessSP());
             if (process_sp)
-            {
-                if (process_sp->GetShouldDetach())
-                    process_sp->Detach();
-            }
+                process_sp->Finalize();
             target_sp->Destroy();
         }
     }