[Lldb-commits] [review request] fix bug that allows users to re-define commands

Malea, Daniel daniel.malea at intel.com
Wed Feb 20 14:36:21 PST 2013


I noticed the TestCommandScript.py test case is failing one line 118, where it verifies that a user cannot redefine a command named 'frame'.

I believe the failure is due to CommandObjectCommands.cpp passing the wrong value (true) for the 'can_replace' parameter to CommandInterpreter::AddUserCommand… When this is set to 'true', which allows the test-case to re-define the 'frame' command to be something else.

Attached patch should fix it. Any concerns/comments, or can I commit this as-is?

I'm still not exactly sure how CommandObjectCommands works, and why there's two code paths that end up calling AddUserCommand..so I figured I'd run it by the list first.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_test_command_script.patch
Type: application/octet-stream
Size: 1343 bytes
Desc: fix_test_command_script.patch
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130220/784a653c/attachment.obj>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: ATT00001.txt
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130220/784a653c/attachment.txt>

More information about the lldb-commits mailing list