[Lldb-commits] [lldb] r175664 - Fix TestPublicAPIHeaders test on Linux.

Matt Kopec Matt.Kopec at intel.com
Wed Feb 20 12:54:11 PST 2013


Author: mkopec
Date: Wed Feb 20 14:54:10 2013
New Revision: 175664

URL: http://llvm.org/viewvc/llvm-project?rev=175664&view=rev
Log:
Fix TestPublicAPIHeaders test on Linux.
 -Change the build_dir variable name to lib_dir
 -Set lib_dir to the correct location on Linux
 -Set LD_EXTRAS to the actual lldb library

Modified:
    lldb/trunk/test/api/check_public_api_headers/Makefile
    lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py
    lldb/trunk/test/dotest.py

Modified: lldb/trunk/test/api/check_public_api_headers/Makefile
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/api/check_public_api_headers/Makefile?rev=175664&r1=175663&r2=175664&view=diff
==============================================================================
--- lldb/trunk/test/api/check_public_api_headers/Makefile (original)
+++ lldb/trunk/test/api/check_public_api_headers/Makefile Wed Feb 20 14:54:10 2013
@@ -6,7 +6,7 @@ MY_OS = $(shell uname -s)
 ifeq "$(MY_OS)" "Darwin"
     LD_EXTRAS ?= -framework LLDB
 else
-    LD_EXTRAS ?= $(LLDB_BUILD_DIR)/_lldb.so
+    LD_EXTRAS ?= $(LLDB_LIB_DIR)/liblldb.so
 endif
 
 # Example dictionary to pass to the Python build method:

Modified: lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py?rev=175664&r1=175663&r2=175664&view=diff
==============================================================================
--- lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py (original)
+++ lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py Wed Feb 20 14:54:10 2013
@@ -14,7 +14,7 @@ class SBDirCheckerCase(TestBase):
 
     def setUp(self):
         TestBase.setUp(self)
-        self.build_dir = os.environ["LLDB_BUILD_DIR"]
+        self.lib_dir = os.environ["LLDB_LIB_DIR"]
         self.template = 'main.cpp.template'
         self.source = 'main.cpp'
 
@@ -28,7 +28,7 @@ class SBDirCheckerCase(TestBase):
         self.generate_main_cpp()
 
         if sys.platform.startswith("darwin"):
-            d = {'FRAMEWORK_INCLUDES' : "-F%s" % self.build_dir}
+            d = {'FRAMEWORK_INCLUDES' : "-F%s" % self.lib_dir}
         if sys.platform.startswith("linux") or os.environ.get('LLDB_BUILD_TYPE') == 'Makefile':
             d = {'FRAMEWORK_INCLUDES' : "-I%s" % os.path.join(os.environ["LLDB_SRC"], "include")}
         self.buildDefault(dictionary=d)
@@ -71,10 +71,10 @@ class SBDirCheckerCase(TestBase):
 
         if sys.platform.startswith("darwin"):
             env_var = 'DYLD_FRAMEWORK_PATH'
-            env_val = self.build_dir
+            env_val = self.lib_dir
         if sys.platform.startswith("linux"):
             env_var = 'LD_LIBRARY_PATH'
-            env_val = self.build_dir
+            env_val = self.lib_dir
 
         env_cmd = "settings set target.env-vars %s=%s" %(env_var, env_val)
         if self.TraceOn():

Modified: lldb/trunk/test/dotest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/dotest.py?rev=175664&r1=175663&r2=175664&view=diff
==============================================================================
--- lldb/trunk/test/dotest.py (original)
+++ lldb/trunk/test/dotest.py Wed Feb 20 14:54:10 2013
@@ -820,9 +820,9 @@ def setupSysPath():
     
     if lldbHere:
         os.environ["LLDB_HERE"] = lldbHere
-        os.environ["LLDB_BUILD_DIR"] = os.path.split(lldbHere)[0]
+        os.environ["LLDB_LIB_DIR"] = os.path.split(lldbHere)[0]
         if not noHeaders:
-            print "LLDB build dir:", os.environ["LLDB_BUILD_DIR"]
+            print "LLDB library dir:", os.environ["LLDB_LIB_DIR"]
             os.system('%s -v' % lldbHere)
 
     if not lldbExec:
@@ -870,7 +870,7 @@ def setupSysPath():
             if len(lines) == 1 and os.path.isfile(os.path.join(lines[0], init_in_python_dir)):
                 lldbPath = lines[0]
                 if "linux" in sys.platform:
-                    os.environ['LLDB_BUILD_DIR'] = os.path.join(lldbPath, 'lldb')
+                    os.environ['LLDB_LIB_DIR'] = os.path.join(lldbPath, '..', '..')
         
         if not lldbPath: 
             dbgPath  = os.path.join(base, *(xcode3_build_dir + dbg + python_resource_dir))





More information about the lldb-commits mailing list