[Lldb-commits] [lldb] r174772 - Fixed a crash when we didn't get a plist but tried

Sean Callanan scallanan at apple.com
Fri Feb 8 15:17:18 PST 2013


Author: spyffe
Date: Fri Feb  8 17:17:17 2013
New Revision: 174772

URL: http://llvm.org/viewvc/llvm-project?rev=174772&view=rev
Log:
Fixed a crash when we didn't get a plist but tried
to pass it to CFGetTypeID() anyway.

<rdar://problem/13181904>

Modified:
    lldb/trunk/source/Host/macosx/Symbols.cpp

Modified: lldb/trunk/source/Host/macosx/Symbols.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/macosx/Symbols.cpp?rev=174772&r1=174771&r2=174772&view=diff
==============================================================================
--- lldb/trunk/source/Host/macosx/Symbols.cpp (original)
+++ lldb/trunk/source/Host/macosx/Symbols.cpp Fri Feb  8 17:17:17 2013
@@ -758,7 +758,7 @@ Symbols::DownloadObjectAndSymbolFile (Mo
                     
                     CFCReleaser<CFDictionaryRef> plist((CFDictionaryRef)::CFPropertyListCreateFromXMLData (NULL, data.get(), kCFPropertyListImmutable, NULL));
                     
-                    if (CFGetTypeID (plist.get()) == CFDictionaryGetTypeID ())
+                    if (plist.get() && CFGetTypeID (plist.get()) == CFDictionaryGetTypeID ())
                     {
                         if (uuid_cstr)
                         {





More information about the lldb-commits mailing list