[Lldb-commits] [lldb] r173894 - Fix one obvious thinko with the plugin.dynamic-loader.darwin-kernel.scan-type setting

Jason Molenda jmolenda at apple.com
Tue Jan 29 20:48:16 PST 2013


Author: jmolenda
Date: Tue Jan 29 22:48:16 2013
New Revision: 173894

URL: http://llvm.org/viewvc/llvm-project?rev=173894&view=rev
Log:
Fix one obvious thinko with the plugin.dynamic-loader.darwin-kernel.scan-type setting
handling that was probably the source of the settings problem.  Need to verify that
it's working correctly tomorrow though.


Modified:
    lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp

Modified: lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp?rev=173894&r1=173893&r2=173894&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp (original)
+++ lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp Tue Jan 29 22:48:16 2013
@@ -49,7 +49,7 @@ enum KASLRScanType
 {
     eKASLRScanNone = 0,         // No reading into the inferior at all
     eKASLRScanLowgloAddresses,  // Check one word of memory for a possible kernel addr, then see if a kernel is there
-    eKASLRScanNearPC,           // Scan backwards from the current $pc looking for kernel; checking at 64 locations total
+    eKASLRScanNearPC,           // Scan backwards from the current $pc looking for kernel; checking at 96 locations total
     eKASLRScanExhaustiveScan    // Scan through the entire possible kernel address range looking for a kernel
 };
 
@@ -110,7 +110,7 @@ public:
     GetScanType() const
     {
         const uint32_t idx = ePropertyScanType;
-        return (KASLRScanType) m_collection_sp->SetPropertyAtIndexAsEnumeration (NULL, idx, g_properties[idx].default_uint_value);
+        return (KASLRScanType) m_collection_sp->GetPropertyAtIndexAsEnumeration (NULL, idx, g_properties[idx].default_uint_value);
     }
 
 





More information about the lldb-commits mailing list