[Lldb-commits] [review request] fix test cases with hardcoded "-arch x86_64"

[Enrico Granata]

Looks reasonable to me.
Thanks for the log. We will make sure to look into it.

Enrico Granata
✉ egranata@.com
✆ (408) 972-7683

On Jan 24, 2013, at 5:11 PM, "Malea, Daniel" <daniel.malea at intel.com> wrote:

> Here’s the crashlog. It looks to be MCJIT-related… the assert is from RuntimeDyldMachO::processRelocationRef().
>  
> Cheers,
> Dan
>  
> From: Enrico Granata [mailto:egranata at apple.com] 
> Sent: Thursday, January 24, 2013 7:49 PM
> To: Malea, Daniel
> Cc: lldb-commits at cs.uiuc.edu
> Subject: Re: [Lldb-commits] [review request] fix test cases with hardcoded "-arch x86_64"
>  
> That test case checks whether the expression parser deals correctly with Unicode strings.
> It would be interesting to get a crash log for your failure, but with that said, since it is currently doomed to fail I am not opposed to skipping it on i386.
> We can revise that when the issue gets fixed to make sure it is fixed on both x86_64 and i386.
>  
> Comments anyone?
>  
> Enrico Granata
> ✉ egranata@.com
> ✆ (408) 972-7683
>  
> On Jan 24, 2013, at 4:43 PM, "Malea, Daniel" <daniel.malea at intel.com> wrote:
> 
> 
> Hi all,
> 
> 
> There's a few test-cases with Makefiles that have "-arch x86_64" hardcoded. This makes it so the tests are only run on 64-bit mode and never on 32-bit mode. I have a patch that fixes this problem; see attached.
> 
> However, one of the test-cases (rdar122991846) causes lldb to crash when built with "-arch i386". It's currently marked as expected-to-fail on 64-bits. 
> 
> Is the patch OK to submit as-is? Should I disable the test-case in question, maybe with a "@skipIfi386" decorator? I only ask because actual crashes (as opposed to just failures) are very annoying, for us Linux folk at least, as they crash the entire "dotest.py" testing tool…. 
> 
> 
> 
> Cheers,
> Dan
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>  
> <rdar12991846_i386_crashlog.txt>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20130124/54e68a4e/attachment.html>