[Lldb-commits] [review request] fix test cases with hardcoded "-arch x86_64"
egranata at apple.com
Thu Jan 24 16:48:47 PST 2013
That test case checks whether the expression parser deals correctly with Unicode strings.
It would be interesting to get a crash log for your failure, but with that said, since it is currently doomed to fail I am not opposed to skipping it on i386.
We can revise that when the issue gets fixed to make sure it is fixed on both x86_64 and i386.
✆ (408) 972-7683
On Jan 24, 2013, at 4:43 PM, "Malea, Daniel" <daniel.malea at intel.com> wrote:
> Hi all,
> There's a few test-cases with Makefiles that have "-arch x86_64" hardcoded. This makes it so the tests are only run on 64-bit mode and never on 32-bit mode. I have a patch that fixes this problem; see attached.
> However, one of the test-cases (rdar122991846) causes lldb to crash when built with "-arch i386". It's currently marked as expected-to-fail on 64-bits.
> Is the patch OK to submit as-is? Should I disable the test-case in question, maybe with a "@skipIfi386" decorator? I only ask because actual crashes (as opposed to just failures) are very annoying, for us Linux folk at least, as they crash the entire "dotest.py" testing tool….
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits