[Lldb-commits] [lldb] r173111 - /lldb/trunk/include/lldb/Core/FormatNavigator.h

Enrico Granata egranata at apple.com
Mon Jan 21 17:43:59 PST 2013

Author: enrico
Date: Mon Jan 21 19:43:59 2013
New Revision: 173111

URL: http://llvm.org/viewvc/llvm-project?rev=173111&view=rev
Replacing a "no clue why" comment with the explanation it was demanding


Modified: lldb/trunk/include/lldb/Core/FormatNavigator.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/FormatNavigator.h?rev=173111&r1=173110&r2=173111&view=diff
--- lldb/trunk/include/lldb/Core/FormatNavigator.h (original)
+++ lldb/trunk/include/lldb/Core/FormatNavigator.h Mon Jan 21 19:43:59 2013
@@ -525,8 +525,10 @@
         return false;
+    // we are separately passing in valobj and type because the valobj is fixed (and is used for ObjC discovery and bitfield size)
+    // but the type can change (e.g. stripping pointers, ...)
     bool Get (ValueObject& valobj,
-              clang::QualType type, // TODO: find out why "type" is passed in the type when it belongs to valobj? Can it ever differ?
+              clang::QualType type,
               MapValueType& entry,
               lldb::DynamicValueType use_dynamic,
               uint32_t& reason)

More information about the lldb-commits mailing list