[Lldb-commits] [lldb] r168375 - in /lldb/trunk/test: functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py types/TestFloatTypes.py types/TestFloatTypesExpr.py types/TestIntegerTypes.py types/TestIntegerTypesExpr.py
Malea, Daniel
daniel.malea at intel.com
Tue Nov 20 11:03:45 PST 2012
Sure, will do Filipe! Thanks for catching this. I'll add a statement in the cleanup routine to turn off auto-confirm.
Dan
On 2012-11-20, at 1:57 PM, Filipe Cabecinhas wrote:
Shouldn't we set it back to what it was before, after finishing the test?
Some tests have failed in the past due to settings being set for one completely orthogonal test.
Regards,
Filipe
F
On Tue, Nov 20, 2012 at 10:53 AM, Daniel Malea <daniel.malea at intel.com<mailto:daniel.malea at intel.com>> wrote:
Author: dmalea
Date: Tue Nov 20 12:53:21 2012
New Revision: 168375
URL: http://llvm.org/viewvc/llvm-project?rev=168375&view=rev
Log:
Use auto-confirm setting to avoid prompts causing some tests to appear to hang
- this commit addresses bugzilla #14385
Modified:
lldb/trunk/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
lldb/trunk/test/types/TestFloatTypes.py
lldb/trunk/test/types/TestFloatTypesExpr.py
lldb/trunk/test/types/TestIntegerTypes.py
lldb/trunk/test/types/TestIntegerTypesExpr.py
Modified: lldb/trunk/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py?rev=168375&r1=168374&r2=168375&view=diff
==============================================================================
--- lldb/trunk/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py (original)
+++ lldb/trunk/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py Tue Nov 20 12:53:21 2012
@@ -26,7 +26,6 @@
self.breakpoint_command_sequence()
self.breakpoint_command_script_parameters ()
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_with_dwarf(self):
"""Test a sequence of breakpoint command add, list, and delete."""
@@ -39,6 +38,8 @@
TestBase.setUp(self)
# Find the line number to break inside main().
self.line = line_number('main.c', '// Set break point at this line.')
+ # disable "There is a running process, kill it and restart?" prompt
+ self.runCmd("settings set auto-confirm true")
def breakpoint_command_sequence(self):
"""Test a sequence of breakpoint command add, list, and delete."""
Modified: lldb/trunk/test/types/TestFloatTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/types/TestFloatTypes.py?rev=168375&r1=168374&r2=168375&view=diff
==============================================================================
--- lldb/trunk/test/types/TestFloatTypes.py (original)
+++ lldb/trunk/test/types/TestFloatTypes.py Tue Nov 20 12:53:21 2012
@@ -12,6 +12,12 @@
mydir = "types"
+ def setUp(self):
+ # Call super's setUp().
+ AbstractBase.GenericTester.setUp(self)
+ # disable "There is a running process, kill it and restart?" prompt
+ self.runCmd("settings set auto-confirm true")
+
@unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")
@dsym_test
def test_float_type_with_dsym(self):
@@ -24,7 +30,6 @@
"""Test that float-type variables are displayed correctly from a block."""
self.build_and_run('float.cpp', set(['float']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_float_type_with_dwarf(self):
"""Test that float-type variables are displayed correctly."""
@@ -42,7 +47,6 @@
"""Test that double-type variables are displayed correctly from a block."""
self.build_and_run('double.cpp', set(['double']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_double_type_with_dwarf(self):
"""Test that double-type variables are displayed correctly."""
Modified: lldb/trunk/test/types/TestFloatTypesExpr.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/types/TestFloatTypesExpr.py?rev=168375&r1=168374&r2=168375&view=diff
==============================================================================
--- lldb/trunk/test/types/TestFloatTypesExpr.py (original)
+++ lldb/trunk/test/types/TestFloatTypesExpr.py Tue Nov 20 12:53:21 2012
@@ -15,6 +15,12 @@
# rdar://problem/8493023
# test/types failures for Test*TypesExpr.py: element offset computed wrong and sign error?
+ def setUp(self):
+ # Call super's setUp().
+ AbstractBase.GenericTester.setUp(self)
+ # disable "There is a running process, kill it and restart?" prompt
+ self.runCmd("settings set auto-confirm true")
+
@unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")
@dsym_test
def test_float_type_with_dsym(self):
@@ -27,7 +33,6 @@
"""Test that float-type variables are displayed correctly from a block."""
self.build_and_run_expr('float.cpp', set(['float']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_float_type_with_dwarf(self):
"""Test that float-type variable expressions are evaluated correctly."""
@@ -45,7 +50,6 @@
"""Test that double-type variables are displayed correctly from a block."""
self.build_and_run_expr('double.cpp', set(['double']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_double_type_with_dwarf(self):
"""Test that double-type variable expressions are evaluated correctly."""
Modified: lldb/trunk/test/types/TestIntegerTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/types/TestIntegerTypes.py?rev=168375&r1=168374&r2=168375&view=diff
==============================================================================
--- lldb/trunk/test/types/TestIntegerTypes.py (original)
+++ lldb/trunk/test/types/TestIntegerTypes.py Tue Nov 20 12:53:21 2012
@@ -12,6 +12,12 @@
mydir = "types"
+ def setUp(self):
+ # Call super's setUp().
+ AbstractBase.GenericTester.setUp(self)
+ # disable "There is a running process, kill it and restart?" prompt
+ self.runCmd("settings set auto-confirm true")
+
@unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")
@dsym_test
def test_char_type_with_dsym(self):
@@ -24,7 +30,6 @@
"""Test that char-type variables are displayed correctly from a block."""
self.build_and_run('char.cpp', set(['char']), bc=True, qd=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_char_type_with_dwarf(self):
"""Test that char-type variables are displayed correctly."""
@@ -42,7 +47,6 @@
"""Test that 'unsigned char'-type variables are displayed correctly from a block."""
self.build_and_run('unsigned_char.cpp', set(['unsigned', 'char']), bc=True, qd=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_unsigned_char_type_with_dwarf(self):
"""Test that 'unsigned char'-type variables are displayed correctly."""
@@ -60,7 +64,6 @@
"""Test that short-type variables are displayed correctly from a block."""
self.build_and_run('short.cpp', set(['short']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_short_type_with_dwarf(self):
"""Test that short-type variables are displayed correctly."""
@@ -78,7 +81,6 @@
"""Test that 'unsigned short'-type variables are displayed correctly from a block."""
self.build_and_run('unsigned_short.cpp', set(['unsigned', 'short']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_unsigned_short_type_with_dwarf(self):
"""Test that 'unsigned short'-type variables are displayed correctly."""
@@ -96,7 +98,6 @@
"""Test that int-type variables are displayed correctly from a block."""
self.build_and_run('int.cpp', set(['int']), dsym=False)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_int_type_with_dwarf(self):
"""Test that int-type variables are displayed correctly."""
@@ -114,7 +115,6 @@
"""Test that 'unsigned int'-type variables are displayed correctly from a block."""
self.build_and_run('unsigned_int.cpp', set(['unsigned', 'int']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_unsigned_int_type_with_dwarf(self):
"""Test that 'unsigned int'-type variables are displayed correctly."""
@@ -132,7 +132,6 @@
"""Test that long-type variables are displayed correctly from a block."""
self.build_and_run('long.cpp', set(['long']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_long_type_with_dwarf(self):
"""Test that long-type variables are displayed correctly."""
@@ -150,7 +149,6 @@
"""Test that 'unsigned_long'-type variables are displayed correctly from a block."""
self.build_and_run('unsigned_long.cpp', set(['unsigned', 'long']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_unsigned_long_type_with_dwarf(self):
"""Test that 'unsigned long'-type variables are displayed correctly."""
@@ -171,7 +169,6 @@
"""Test that 'long_long'-type variables are displayed correctly from a block."""
self.build_and_run('long_long.cpp', set(['long long']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_long_long_type_with_dwarf(self):
"""Test that 'long long'-type variables are displayed correctly."""
@@ -189,7 +186,6 @@
"""Test that 'unsigned_long_long'-type variables are displayed correctly from a block."""
self.build_and_run('unsigned_long_long.cpp', set(['unsigned', 'long long']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_unsigned_long_long_type_with_dwarf(self):
"""Test that 'unsigned long long'-type variables are displayed correctly."""
Modified: lldb/trunk/test/types/TestIntegerTypesExpr.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/types/TestIntegerTypesExpr.py?rev=168375&r1=168374&r2=168375&view=diff
==============================================================================
--- lldb/trunk/test/types/TestIntegerTypesExpr.py (original)
+++ lldb/trunk/test/types/TestIntegerTypesExpr.py Tue Nov 20 12:53:21 2012
@@ -12,6 +12,12 @@
mydir = "types"
+ def setUp(self):
+ # Call super's setUp().
+ AbstractBase.GenericTester.setUp(self)
+ # disable "There is a running process, kill it and restart?" prompt
+ self.runCmd("settings set auto-confirm true")
+
@unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")
@dsym_test
def test_char_type_with_dsym(self):
@@ -24,7 +30,6 @@
"""Test that char-type variables are displayed correctly from a block."""
self.build_and_run_expr('char.cpp', set(['char']), bc=True, qd=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_char_type_with_dwarf(self):
"""Test that char-type variable expressions are evaluated correctly."""
@@ -42,7 +47,6 @@
"""Test that 'unsigned char'-type variables are displayed correctly from a block."""
self.build_and_run_expr('unsigned_char.cpp', set(['unsigned', 'char']), bc=True, qd=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_unsigned_char_type_with_dwarf(self):
"""Test that 'unsigned char'-type variable expressions are evaluated correctly."""
@@ -60,7 +64,6 @@
"""Test that short-type variables are displayed correctly from a block."""
self.build_and_run_expr('short.cpp', set(['short']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_short_type_with_dwarf(self):
"""Test that short-type variable expressions are evaluated correctly."""
@@ -78,7 +81,6 @@
"""Test that 'unsigned short'-type variables are displayed correctly from a block."""
self.build_and_run_expr('unsigned_short.cpp', set(['unsigned', 'short']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_unsigned_short_type_with_dwarf(self):
"""Test that 'unsigned short'-type variable expressions are evaluated correctly."""
@@ -96,7 +98,6 @@
"""Test that int-type variables are displayed correctly from a block."""
self.build_and_run_expr('int.cpp', set(['int']), dsym=False)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_int_type_with_dwarf(self):
"""Test that int-type variable expressions are evaluated correctly."""
@@ -114,7 +115,6 @@
"""Test that 'unsigned int'-type variables are displayed correctly from a block."""
self.build_and_run_expr('unsigned_int.cpp', set(['unsigned', 'int']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_unsigned_int_type_with_dwarf(self):
"""Test that 'unsigned int'-type variable expressions are evaluated correctly."""
@@ -132,7 +132,6 @@
"""Test that long-type variables are displayed correctly from a block."""
self.build_and_run_expr('long.cpp', set(['long']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_long_type_with_dwarf(self):
"""Test that long-type variable expressions are evaluated correctly."""
@@ -150,7 +149,6 @@
"""Test that 'unsigned_long'-type variables are displayed correctly from a block."""
self.build_and_run_expr('unsigned_long.cpp', set(['unsigned', 'long']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_unsigned_long_type_with_dwarf(self):
"""Test that 'unsigned long'-type variable expressions are evaluated correctly."""
@@ -171,7 +169,6 @@
"""Test that 'long_long'-type variables are displayed correctly from a block."""
self.build_and_run_expr('long_long.cpp', set(['long long']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_long_long_type_with_dwarf(self):
"""Test that 'long long'-type variable expressions are evaluated correctly."""
@@ -189,7 +186,6 @@
"""Test that 'unsigned_long_long'-type variables are displayed correctly from a block."""
self.build_and_run_expr('unsigned_long_long.cpp', set(['unsigned', 'long long']), bc=True)
- @unittest2.skipIf(sys.platform.startswith("linux"), "Hanging on Linux: bugzilla #14385")
@dwarf_test
def test_unsigned_long_long_type_with_dwarf(self):
"""Test that 'unsigned long long'-type variable expressions are evaluated correctly."""
_______________________________________________
lldb-commits mailing list
lldb-commits at cs.uiuc.edu<mailto:lldb-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
More information about the lldb-commits
mailing list