[Lldb-commits] [lldb] r166315 - /lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp

[Greg Clayton]

Author: gclayton
Date: Fri Oct 19 15:53:18 2012
New Revision: 166315

URL: http://llvm.org/viewvc/llvm-project?rev=166315&view=rev
Log:
Change the name of the variable used to detect if we are loading kexts to "load-kexts" instead of "disable-kext-loading" since the value is a boolean. This was requested by the person who requested the feature. It now defaults to true:

(lldb) settings show plugin.dynamic-loader.darwin-kernel.load-kexts
plugin.dynamic-loader.darwin-kernel.load-kexts (boolean) = true



Modified:
    lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp

Modified: lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp?rev=166315&r1=166314&r2=166315&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp (original)
+++ lldb/trunk/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp Fri Oct 19 15:53:18 2012
@@ -42,12 +42,12 @@
 static PropertyDefinition
 g_properties[] =
 {
-    { "disable-kext-loading" , OptionValue::eTypeBoolean, false, false, NULL, NULL, "Disable kext image loading in a Darwin kernel debug session." },
-    {  NULL                  , OptionValue::eTypeInvalid, false, 0    , NULL, NULL, NULL  }
+    { "load-kexts" , OptionValue::eTypeBoolean, true, true, NULL, NULL, "Automatically loads kext images when attaching to a kernel." },
+    {  NULL        , OptionValue::eTypeInvalid, false, 0  , NULL, NULL, NULL  }
 };
 
 enum {
-    ePropertyDisableKextLoading
+    ePropertyLoadKexts
 };
 
 class DynamicLoaderDarwinKernelProperties : public Properties
@@ -74,9 +74,9 @@
     }
     
     bool
-    GetDisableKextLoading() const
+    GetLoadKexts() const
     {
-        const uint32_t idx = ePropertyDisableKextLoading;
+        const uint32_t idx = ePropertyLoadKexts;
         return m_collection_sp->GetPropertyAtIndexAsBoolean (NULL, idx, g_properties[idx].default_uint_value != 0);
     }
     
@@ -244,7 +244,7 @@
     ModuleSP memory_module_sp;
 
     // If this is a kext and the user asked us to ignore kexts, don't try to load it.
-    if (kernel_image == false && GetGlobalProperties()->GetDisableKextLoading() == true)
+    if (kernel_image == false && GetGlobalProperties()->GetLoadKexts() == false)
     {
         return false;
     }