[Lldb-commits] [lldb] r166258 - in /lldb/trunk: include/lldb/Core/Stream.h source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp

[Jason Molenda]

Author: jmolenda
Date: Thu Oct 18 21:16:22 2012
New Revision: 166258

URL: http://llvm.org/viewvc/llvm-project?rev=166258&view=rev
Log:
Change CommunicationKDP::SendRequestWriteMemory to append data as binary
instead of asciified bytes.  <rdar://problem/12522978>

Modified:
    lldb/trunk/include/lldb/Core/Stream.h
    lldb/trunk/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp

Modified: lldb/trunk/include/lldb/Core/Stream.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/Stream.h?rev=166258&r1=166257&r2=166258&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Core/Stream.h (original)
+++ lldb/trunk/include/lldb/Core/Stream.h Thu Oct 18 21:16:22 2012
@@ -179,12 +179,15 @@
     int
     PutPointer (void *ptr);
 
+    // Append \a src_len bytes from \s to the stream as hex characters
+    // (two ascii characters per byte of input data)
     int
     PutBytesAsRawHex8 (const void *src,
                        size_t src_len,
                        lldb::ByteOrder src_byte_order = lldb::eByteOrderInvalid,
                        lldb::ByteOrder dst_byte_order = lldb::eByteOrderInvalid);
 
+    // Append \a src_len bytes from \s to the stream as binary data.
     int
     PutRawBytes (const void *s, 
                  size_t src_len,

Modified: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp?rev=166258&r1=166257&r2=166258&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp (original)
+++ lldb/trunk/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.cpp Thu Oct 18 21:16:22 2012
@@ -676,7 +676,7 @@
     MakeRequestPacketHeader (command, request_packet, command_length);
     request_packet.PutMaxHex64 (addr, command_addr_byte_size);
     request_packet.PutHex32 (src_len);
-    request_packet.PutBytesAsRawHex8(src, src_len);
+    request_packet.PutRawBytes(src, src_len);
 
     DataExtractor reply_packet;
     if (SendRequestAndGetReply (command, request_sequence_id, request_packet, reply_packet))