[Lldb-commits] [PATCH] build fixes for Linux

[Malea, Daniel]

Hi Enrico, please find the updated patch attached.

It is identical to the previous, except for PlatformRemoteiOS.cpp. It now uses the same approach as the other #ifdef block on line 125 of the same file.

Thanks a bunch,
Dan

From: Enrico Granata [mailto:egranata at apple.com]
Sent: Wednesday, September 05, 2012 8:44 PM
To: Malea, Daniel
Cc: lldb-commits at cs.uiuc.edu
Subject: Re: [Lldb-commits] [PATCH] build fixes for Linux

If you have a better idea, feel free to submit a new patch with the better changes :-)

Enrico Granata
✉ egranata@.com<mailto:egranata@.com>
✆ (408) 972-7683

On Sep 5, 2012, at 4:31 PM, "Malea, Daniel" <daniel.malea at intel.com<mailto:daniel.malea at intel.com>> wrote:


Thanks for taking a look Enrico. The PlatformRemoteiOS.cpp change just matches the brace from line 100 when __APPLE__ is not defined. However, on a closer inspection, it may be best to have the entire "default:" case outside the ifdef...


Dan


On 2012-09-05, at 6:40 PM, "Enrico Granata" <egranata at apple.com<mailto:egranata at apple.com><mailto:egranata at apple.com>> wrote:

I am not sure about the PlatformRemoteiOS.cpp changes - but I have no objection to the other modifications brought in with this patch

Enrico Granata
✉ egranata@.com<mailto:egranata@.com>
✆ (408) 972-7683

On Sep 5, 2012, at 3:19 PM, "Malea, Daniel" <daniel.malea at intel.com<mailto:daniel.malea at intel.com><mailto:daniel.malea at intel.com>> wrote:

Hi,

I noticed a few build problems on Linux introduced by recent commits. Please find the attached patch that addresses:
- missing include of stdint.h (required for int64_t)
- null return type in functions that must return SP
- off-by-one-line brace typo in PlatformRemoteiOS.cpp

With the patch applied (and the recently-comitted clang patch to enable the UTF functions) I am able to build trunk lldb on Linux :)

Cheers,
Dan

PS. git patch, so apply with -p1

<lldb_incl_rettype_ios_buildfix.patch>_______________________________________________
lldb-commits mailing list
lldb-commits at cs.uiuc.edu<mailto:lldb-commits at cs.uiuc.edu><mailto:lldb-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20120906/b8840ea5/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lldb_incl_rettype_ios_buildfix_v2.patch
Type: application/octet-stream
Size: 3060 bytes
Desc: lldb_incl_rettype_ios_buildfix_v2.patch
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20120906/b8840ea5/attachment.obj>