[Lldb-commits] [lldb] r161493 - /lldb/trunk/test/dotest.py

[Greg Clayton]

On Aug 30, 2012, at 8:37 AM, Filipe Cabecinhas <filcab at filcab.net> wrote:

> Hi Greg, 
> 
> This is (mostly?) fixed.

Very nice.

> But we lose one functionality: Being able to specify different CFLAGS for each architecture. Is this an often used feature of the test-suite?

Not to my knowledge.

> The formatting for some of the help text could be improved, too.

Yes!
> 
> Attached is a proposed patch.
> 
> Please run the patched dotest.py against your favorite invocations of the test suite.

I will try this out and let you know. Thanks for making this happen!

Greg

> 
> Regards, 
> 
>  Filipe
> 
> 
> On Wednesday, August 8, 2012 at 10:37 PM, Greg Clayton wrote:
> 
>> <request>
>> Seeing all these great python fixes makes me want to request that we use the "optparse" module for all option parsing. Right now, if I remember correctly, it is using a custom version. We should fix that!
>> </request>
>> 
>> 
>> On Aug 8, 2012, at 8:23 AM, Filipe Cabecinhas <me at filcab.net (mailto:me at filcab.net)> wrote:
>> 
>>> Author: filcab
>>> Date: Wed Aug 8 10:23:24 2012
>>> New Revision: 161493
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=161493&view=rev
>>> Log:
>>> Indentation fix for dotest.py.
>>> 
>>> Modified:
>>> lldb/trunk/test/dotest.py
>>> 
>>> Modified: lldb/trunk/test/dotest.py
>>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/dotest.py?rev=161493&r1=161492&r2=161493&view=diff
>>> ==============================================================================
>>> --- lldb/trunk/test/dotest.py (original)
>>> +++ lldb/trunk/test/dotest.py Wed Aug 8 10:23:24 2012
>>> @@ -1229,7 +1229,7 @@
>>> rmtree(newrdir)
>>> copytree(rdir, newrdir, ignore=ignore_patterns('*.pyc', '*.o', '*.d'))
>>> 
>>> - # Update the LLDB_TEST environment variable to reflect new top
>>> + # Update the LLDB_TEST environment variable to reflect new top
>>> # level test directory.
>>> #
>>> # See also lldbtest.TestBase.setUpClass(cls).
>>> 
>>> 
>>> _______________________________________________
>>> lldb-commits mailing list
>>> lldb-commits at cs.uiuc.edu (mailto:lldb-commits at cs.uiuc.edu)
>>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>> 
> 
> 
> <argparse.patch>