[Lldb-commits] [lldb] r157678 - /lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py

[Filipe Cabecinhas]

I'm sorry, I replied to the wrong email. That hunk would go to the file patched in revision 157679:

URL: http://llvm.org/viewvc/llvm-project?rev=157679&view=rev
Log:
Mark the test as failing on both architectures, since LLDB won't handle the function to clang.

Modified:
lldb/trunk/test/lang/objc/objc-new-syntax/TestObjCNewSyntax.py

Modified: lldb/trunk/test/lang/objc/objc-new-syntax/TestObjCNewSyntax.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lang/objc/objc-new-syntax/TestObjCNewSyntax.py?rev=157679&r1=157678&r2=157679&view=diff
==============================================================================
--- lldb/trunk/test/lang/objc/objc-new-syntax/TestObjCNewSyntax.py (original)
+++ lldb/trunk/test/lang/objc/objc-new-syntax/TestObjCNewSyntax.py Wed May 30 00:44:59 2012
@@ -13,13 +13,13 @@

mydir = os.path.join("lang", "objc", "objc-new-syntax")

- @expectedFailurei386
+ @unittest2.expectedFailure
@dsym_test
def test_expr_with_dsym(self):
self.buildDsym()
self.expr()

- @expectedFailurei386
+ @unittest2.expectedFailure
@dwarf_test
def test_expr_with_dwarf(self):
self.buildDwarf()



Regards, 

  Filipe


On Wednesday, May 30, 2012 at 1:49 PM, Filipe Cabecinhas wrote:

> I suppose this hunk should also be included: 
> 
> @@ -34,7 +34,7 @@
> def applies(self):
> if platform.system() != "Darwin":
> return False
> - if StrictVersion('12.0.0') > platform.release():
> + if StrictVersion('11.0.0') > platform.release():
> return False
> 
> return True
> 
> 
> 
> But I want to confirm it. Sean?
> 
> Thanks, 
> 
> Filipe
> 
> 
> On Wednesday, May 30, 2012 at 1:40 PM, Filipe Cabecinhas wrote:
> 
> > Author: filcab
> > Date: Wed May 30 00:40:23 2012
> > New Revision: 157678
> > 
> > URL: http://llvm.org/viewvc/llvm-project?rev=157678&view=rev
> > Log:
> > Make the test suite work again on Mac OS X without the LLDB_BUILD_TYPE env var
> > 
> > Modified:
> > lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py
> > 
> > Modified: lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py
> > URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py?rev=157678&r1=157677&r2=157678&view=diff
> > ==============================================================================
> > --- lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py (original)
> > +++ lldb/trunk/test/api/check_public_api_headers/TestPublicAPIHeaders.py Wed May 30 00:40:23 2012
> > @@ -28,7 +28,7 @@
> > 
> > if sys.platform.startswith("darwin"):
> > d = {'FRAMEWORK_INCLUDES' : "-F%s" % self.build_dir}
> > - if sys.platform.startswith("linux"):
> > + if sys.platform.startswith("linux") or os.environ.get('LLDB_BUILD_TYPE') == 'Makefile':
> > d = {'FRAMEWORK_INCLUDES' : "-I%s" % os.path.join(os.environ["LLDB_SRC"], "include")}
> > self.buildDefault(dictionary=d)
> > self.exe_name = 'a.out'
> > @@ -48,7 +48,7 @@
> > # For different platforms, the include statement can vary.
> > if sys.platform.startswith("darwin"):
> > include_stmt = "'#include <%s>' % os.path.join('LLDB', header)"
> > - if sys.platform.startswith("linux"):
> > + if sys.platform.startswith("linux") or os.environ.get('LLDB_BUILD_TYPE') == 'Makefile':
> > include_stmt = "'#include <%s>' % os.path.join(public_api_dir, header)"
> > list = [eval(include_stmt) for header in public_headers if (header.startswith("SB") and
> > header.endswith(".h"))]
> > 
> > 
> > _______________________________________________
> > lldb-commits mailing list
> > lldb-commits at cs.uiuc.edu (mailto:lldb-commits at cs.uiuc.edu)
> > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>