[Lldb-commits] [lldb] r155175 - /lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp

Jim Ingham jingham at apple.com
Thu Apr 19 17:08:56 PDT 2012


Author: jingham
Date: Thu Apr 19 19:08:56 2012
New Revision: 155175

URL: http://llvm.org/viewvc/llvm-project?rev=155175&view=rev
Log:
Missed one place where the assert should have been in a #ifdef.  Thanks Jason.

Modified:
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp?rev=155175&r1=155174&r2=155175&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp Thu Apr 19 19:08:56 2012
@@ -452,7 +452,7 @@
             StreamString strm;
             gdb_comm.DumpHistory(strm);
             Host::SetCrashDescription (strm.GetData());
-            assert (!"Didn't get sequence mutex.");
+            assert (!"Didn't get sequence mutex for write register.");
 #else
             if (log)
             {
@@ -529,7 +529,7 @@
         StreamString strm;
         gdb_comm.DumpHistory(strm);
         Host::SetCrashDescription (strm.GetData());
-        assert (!"Didn't get sequence mutex.");
+        assert (!"Didn't get sequence mutex for read all registers.");
 #else
         if (log)
         {
@@ -665,19 +665,24 @@
     else
     {
         LogSP log (ProcessGDBRemoteLog::GetLogIfAnyCategoryIsSet (GDBR_LOG_THREAD | GDBR_LOG_PACKETS));
-        if (1 /* log */)
+#if LLDB_CONFIGURATION_DEBUG
+        StreamString strm;
+        gdb_comm.DumpHistory(strm);
+        Host::SetCrashDescription (strm.GetData());
+        assert (!"Didn't get sequence mutex for write all registers.");
+#else
+        if (log)
         {
-            if (1 /*log->GetVerbose() */)
+            if (log->GetVerbose())
             {
                 StreamString strm;
                 gdb_comm.DumpHistory(strm);
-                Host::SetCrashDescription (strm.GetData());
-                assert (!"Didn't get sequence mutex.");
                 log->Printf("error: failed to get packet sequence mutex, not sending write all registers:\n%s", strm.GetData());
             }
             else
                 log->Printf("error: failed to get packet sequence mutex, not sending write all registers");
         }
+#endif
     }
     return false;
 }





More information about the lldb-commits mailing list