[Lldb-commits] [lldb] r148756 - in /lldb/trunk: include/lldb/Breakpoint/StoppointLocation.h source/Breakpoint/Watchpoint.cpp

Johnny Chen johnny.chen at apple.com
Mon Jan 23 16:11:02 PST 2012


Author: johnny
Date: Mon Jan 23 18:11:02 2012
New Revision: 148756

URL: http://llvm.org/viewvc/llvm-project?rev=148756&view=rev
Log:
Minor comment change.  Plus use member function instead of directly accessing member field.

Modified:
    lldb/trunk/include/lldb/Breakpoint/StoppointLocation.h
    lldb/trunk/source/Breakpoint/Watchpoint.cpp

Modified: lldb/trunk/include/lldb/Breakpoint/StoppointLocation.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Breakpoint/StoppointLocation.h?rev=148756&r1=148755&r2=148756&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Breakpoint/StoppointLocation.h (original)
+++ lldb/trunk/include/lldb/Breakpoint/StoppointLocation.h Mon Jan 23 18:11:02 2012
@@ -123,7 +123,7 @@
     //------------------------------------------------------------------
     // Classes that inherit from StoppointLocation can see and modify these
     //------------------------------------------------------------------
-    lldb::break_id_t  m_loc_id;     // Break ID
+    lldb::break_id_t  m_loc_id;     // Stoppoint location ID
     lldb::addr_t      m_addr;       // The load address of this stop point. The base Stoppoint doesn't
                                     // store a full Address since that's not needed for the breakpoint sites.
     bool        m_hw_preferred;     // 1 if this point has been requested to be set using hardware (which may fail due to lack of resources)
@@ -131,7 +131,7 @@
     uint32_t    m_byte_size;        // The size in bytes of stop location.  e.g. the length of the trap opcode for
                                     // software breakpoints, or the optional length in bytes for
                                     // hardware breakpoints, or the length of the watchpoint.
-    uint32_t    m_hit_count;        // Number of times this breakpoint has been hit
+    uint32_t    m_hit_count;        // Number of times this breakpoint/watchpoint has been hit
 
 private:
     //------------------------------------------------------------------

Modified: lldb/trunk/source/Breakpoint/Watchpoint.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Breakpoint/Watchpoint.cpp?rev=148756&r1=148755&r2=148756&view=diff
==============================================================================
--- lldb/trunk/source/Breakpoint/Watchpoint.cpp (original)
+++ lldb/trunk/source/Breakpoint/Watchpoint.cpp Mon Jan 23 18:11:02 2012
@@ -115,7 +115,7 @@
 
     s->Printf("Watchpoint %u: addr = 0x%8.8llx size = %u state = %s type = %s%s",
               GetID(),
-              (uint64_t)m_addr,
+              GetLoadAddress(),
               m_byte_size,
               m_enabled ? "enabled" : "disabled",
               m_watch_read ? "r" : "",





More information about the lldb-commits mailing list