[Lldb-commits] [lldb] r144254 - in /lldb/trunk: include/lldb/Target/ThreadPlanRunToAddress.h source/Target/ThreadPlanRunToAddress.cpp

Jim Ingham jingham at apple.com
Wed Nov 9 17:12:26 PST 2011


Author: jingham
Date: Wed Nov  9 19:12:26 2011
New Revision: 144254

URL: http://llvm.org/viewvc/llvm-project?rev=144254&view=rev
Log:
Using the wrong type for the break id's (user_id_t is an unsigned int, but internal breakpoints can be negative, and anyway it is a good idea to use break_id_t for breakpoints, no?)

Modified:
    lldb/trunk/include/lldb/Target/ThreadPlanRunToAddress.h
    lldb/trunk/source/Target/ThreadPlanRunToAddress.cpp

Modified: lldb/trunk/include/lldb/Target/ThreadPlanRunToAddress.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Target/ThreadPlanRunToAddress.h?rev=144254&r1=144253&r2=144254&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Target/ThreadPlanRunToAddress.h (original)
+++ lldb/trunk/include/lldb/Target/ThreadPlanRunToAddress.h Wed Nov  9 19:12:26 2011
@@ -74,7 +74,7 @@
     bool m_stop_others;
     std::vector<lldb::addr_t> m_addresses;   // This is the address we are going to run to.
                           // TODO: Would it be useful to have multiple addresses?
-    std::vector<lldb::user_id_t> m_break_ids; // This is the breakpoint we are using to stop us at m_address.
+    std::vector<lldb::break_id_t> m_break_ids; // This is the breakpoint we are using to stop us at m_address.
 
     DISALLOW_COPY_AND_ASSIGN (ThreadPlanRunToAddress);
 

Modified: lldb/trunk/source/Target/ThreadPlanRunToAddress.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/ThreadPlanRunToAddress.cpp?rev=144254&r1=144253&r2=144254&view=diff
==============================================================================
--- lldb/trunk/source/Target/ThreadPlanRunToAddress.cpp (original)
+++ lldb/trunk/source/Target/ThreadPlanRunToAddress.cpp Wed Nov  9 19:12:26 2011
@@ -152,7 +152,7 @@
             }
             
             s->Address(m_addresses[i], sizeof (addr_t));
-            s->Printf (" using breakpoint: %llu - ", m_break_ids[i]);
+            s->Printf (" using breakpoint: %d - ", m_break_ids[i]);
             Breakpoint *breakpoint = m_thread.GetProcess().GetTarget().GetBreakpointByID (m_break_ids[i]).get();
             if (breakpoint)
                 breakpoint->Dump (s);





More information about the lldb-commits mailing list