[Lldb-commits] [lldb] r140930 - in /lldb/trunk: include/lldb/API/SBDebugger.h include/lldb/API/SBFileSpec.h include/lldb/API/SBSourceManager.h include/lldb/API/SBStream.h include/lldb/API/SBTarget.h include/lldb/lldb-forward.h source/API/SBDebugger.cpp source/API/SBSourceManager.cpp source/API/SBTarget.cpp
Greg Clayton
gclayton at apple.com
Fri Sep 30 19:59:24 PDT 2011
Author: gclayton
Date: Fri Sep 30 21:59:24 2011
New Revision: 140930
URL: http://llvm.org/viewvc/llvm-project?rev=140930&view=rev
Log:
Removed lldb::SBSourceManager_impl. We export everything in the lldb namespace
and this implemenation that backs our lldb::SBSourceManager should not be
exported.
Modified:
lldb/trunk/include/lldb/API/SBDebugger.h
lldb/trunk/include/lldb/API/SBFileSpec.h
lldb/trunk/include/lldb/API/SBSourceManager.h
lldb/trunk/include/lldb/API/SBStream.h
lldb/trunk/include/lldb/API/SBTarget.h
lldb/trunk/include/lldb/lldb-forward.h
lldb/trunk/source/API/SBDebugger.cpp
lldb/trunk/source/API/SBSourceManager.cpp
lldb/trunk/source/API/SBTarget.cpp
Modified: lldb/trunk/include/lldb/API/SBDebugger.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBDebugger.h?rev=140930&r1=140929&r2=140930&view=diff
==============================================================================
--- lldb/trunk/include/lldb/API/SBDebugger.h (original)
+++ lldb/trunk/include/lldb/API/SBDebugger.h Fri Sep 30 21:59:24 2011
@@ -246,8 +246,8 @@
friend class SBInputReader;
friend class SBProcess;
+ friend class SBSourceManager;
friend class SBTarget;
- friend class SBSourceManager_impl;
lldb::SBTarget
FindTargetWithLLDBProcess (const lldb::ProcessSP &processSP);
@@ -261,6 +261,8 @@
lldb_private::Debugger &
ref () const;
+ const lldb::DebuggerSP &
+ get_sp () const;
#endif
lldb::DebuggerSP m_opaque_sp;
Modified: lldb/trunk/include/lldb/API/SBFileSpec.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBFileSpec.h?rev=140930&r1=140929&r2=140930&view=diff
==============================================================================
--- lldb/trunk/include/lldb/API/SBFileSpec.h (original)
+++ lldb/trunk/include/lldb/API/SBFileSpec.h Fri Sep 30 21:59:24 2011
@@ -64,7 +64,7 @@
friend class SBLineEntry;
friend class SBModule;
friend class SBProcess;
- friend class SBSourceManager_impl;
+ friend class SBSourceManager;
friend class SBThread;
friend class SBTarget;
Modified: lldb/trunk/include/lldb/API/SBSourceManager.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBSourceManager.h?rev=140930&r1=140929&r2=140930&view=diff
==============================================================================
--- lldb/trunk/include/lldb/API/SBSourceManager.h (original)
+++ lldb/trunk/include/lldb/API/SBSourceManager.h Fri Sep 30 21:59:24 2011
@@ -16,8 +16,6 @@
namespace lldb {
-class SBSourceManager_impl;
-
class SBSourceManager
{
public:
@@ -49,7 +47,7 @@
private:
- std::auto_ptr<SBSourceManager_impl> m_opaque_ap;
+ std::auto_ptr<lldb_private::SourceManagerImpl> m_opaque_ap;
};
} // namespace lldb
Modified: lldb/trunk/include/lldb/API/SBStream.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBStream.h?rev=140930&r1=140929&r2=140930&view=diff
==============================================================================
--- lldb/trunk/include/lldb/API/SBStream.h (original)
+++ lldb/trunk/include/lldb/API/SBStream.h Fri Sep 30 21:59:24 2011
@@ -61,6 +61,7 @@
friend class SBBlock;
friend class SBBreakpoint;
friend class SBBreakpointLocation;
+ friend class SBCommandReturnObject;
friend class SBCompileUnit;
friend class SBData;
friend class SBEvent;
@@ -70,14 +71,13 @@
friend class SBInstructionList;
friend class SBModule;
friend class SBSection;
- friend class SBSourceManager_impl;
+ friend class SBSourceManager;
friend class SBSymbol;
friend class SBSymbolContext;
friend class SBTarget;
friend class SBThread;
friend class SBValue;
friend class SBWatchpointLocation;
- friend class SBCommandReturnObject;
#ifndef SWIG
Modified: lldb/trunk/include/lldb/API/SBTarget.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBTarget.h?rev=140930&r1=140929&r2=140930&view=diff
==============================================================================
--- lldb/trunk/include/lldb/API/SBTarget.h (original)
+++ lldb/trunk/include/lldb/API/SBTarget.h Fri Sep 30 21:59:24 2011
@@ -502,11 +502,11 @@
friend class SBDebugger;
friend class SBFunction;
friend class SBInstruction;
+ friend class SBModule;
friend class SBProcess;
+ friend class SBSourceManager;
friend class SBSymbol;
- friend class SBModule;
friend class SBValue;
- friend class SBSourceManager_impl;
//------------------------------------------------------------------
// Constructors are private, use static Target::Create function to
@@ -524,6 +524,9 @@
lldb_private::Target *
get() const;
+ const lldb::TargetSP &
+ get_sp () const;
+
private:
//------------------------------------------------------------------
// For Target only
Modified: lldb/trunk/include/lldb/lldb-forward.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/lldb-forward.h?rev=140930&r1=140929&r2=140930&view=diff
==============================================================================
--- lldb/trunk/include/lldb/lldb-forward.h (original)
+++ lldb/trunk/include/lldb/lldb-forward.h Fri Sep 30 21:59:24 2011
@@ -131,6 +131,7 @@
class SectionImpl;
class SectionList;
class SourceManager;
+class SourceManagerImpl;
class StackFrame;
class StackFrameList;
class StackID;
Modified: lldb/trunk/source/API/SBDebugger.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBDebugger.cpp?rev=140930&r1=140929&r2=140930&view=diff
==============================================================================
--- lldb/trunk/source/API/SBDebugger.cpp (original)
+++ lldb/trunk/source/API/SBDebugger.cpp Fri Sep 30 21:59:24 2011
@@ -825,6 +825,11 @@
return *m_opaque_sp;
}
+const lldb::DebuggerSP &
+SBDebugger::get_sp () const
+{
+ return m_opaque_sp;
+}
SBDebugger
SBDebugger::FindDebuggerWithID (int id)
Modified: lldb/trunk/source/API/SBSourceManager.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBSourceManager.cpp?rev=140930&r1=140929&r2=140930&view=diff
==============================================================================
--- lldb/trunk/source/API/SBSourceManager.cpp (original)
+++ lldb/trunk/source/API/SBSourceManager.cpp Fri Sep 30 21:59:24 2011
@@ -20,76 +20,76 @@
#include "lldb/Target/Target.h"
-using namespace lldb;
-using namespace lldb_private;
-
-class lldb::SBSourceManager_impl
+namespace lldb_private
{
-public:
- SBSourceManager_impl (const SBDebugger &debugger)
- {
- m_debugger_sp = debugger.m_opaque_sp;
- }
-
- SBSourceManager_impl (const SBTarget &target)
+ class SourceManagerImpl
{
- m_target_sp = target.m_opaque_sp;
- }
-
- SBSourceManager_impl (const SBSourceManager_impl &rhs)
- {
- if (&rhs == this)
- return;
- m_debugger_sp = rhs.m_debugger_sp;
- m_target_sp = rhs.m_target_sp;
- }
-
- size_t
- DisplaySourceLinesWithLineNumbers
- (
- const SBFileSpec &file,
- uint32_t line,
- uint32_t context_before,
- uint32_t context_after,
- const char* current_line_cstr,
- SBStream &s
- )
- {
- if (!file.IsValid())
- return 0;
+ public:
+ SourceManagerImpl (const lldb::DebuggerSP &debugger_sp)
+ {
+ m_debugger_sp = debugger_sp;
+ }
+
+ SourceManagerImpl (const lldb::TargetSP &target_sp)
+ {
+ m_target_sp = target_sp;
+ }
+
+ SourceManagerImpl (const SourceManagerImpl &rhs)
+ {
+ if (&rhs == this)
+ return;
+ m_debugger_sp = rhs.m_debugger_sp;
+ m_target_sp = rhs.m_target_sp;
+ }
+
+ size_t
+ DisplaySourceLinesWithLineNumbers (const lldb_private::FileSpec &file,
+ uint32_t line,
+ uint32_t context_before,
+ uint32_t context_after,
+ const char* current_line_cstr,
+ lldb_private::Stream *s)
+ {
+ if (file)
+ return 0;
- if (m_debugger_sp)
- return m_debugger_sp->GetSourceManager().DisplaySourceLinesWithLineNumbers (*file,
- line,
- context_before,
- context_after,
- current_line_cstr,
- s.m_opaque_ap.get());
- else if (m_target_sp)
- return m_target_sp->GetSourceManager().DisplaySourceLinesWithLineNumbers (*file,
- line,
- context_before,
- context_after,
- current_line_cstr,
- s.m_opaque_ap.get());
- else
- return 0;
- }
-
-private:
- lldb::DebuggerSP m_debugger_sp;
- lldb::TargetSP m_target_sp;
-
-};
+ if (m_debugger_sp)
+ return m_debugger_sp->GetSourceManager().DisplaySourceLinesWithLineNumbers (file,
+ line,
+ context_before,
+ context_after,
+ current_line_cstr,
+ s);
+ else if (m_target_sp)
+ return m_target_sp->GetSourceManager().DisplaySourceLinesWithLineNumbers (file,
+ line,
+ context_before,
+ context_after,
+ current_line_cstr,
+ s);
+ else
+ return 0;
+ }
+
+ private:
+ lldb::DebuggerSP m_debugger_sp;
+ lldb::TargetSP m_target_sp;
+
+ };
+}
+
+using namespace lldb;
+using namespace lldb_private;
SBSourceManager::SBSourceManager (const SBDebugger &debugger)
{
- m_opaque_ap.reset(new SBSourceManager_impl (debugger));
+ m_opaque_ap.reset(new SourceManagerImpl (debugger.get_sp()));
}
SBSourceManager::SBSourceManager (const SBTarget &target)
{
- m_opaque_ap.reset(new SBSourceManager_impl (target));
+ m_opaque_ap.reset(new SourceManagerImpl (target.get_sp()));
}
SBSourceManager::SBSourceManager (const SBSourceManager &rhs)
@@ -97,13 +97,13 @@
if (&rhs == this)
return;
- m_opaque_ap.reset(new SBSourceManager_impl (*(rhs.m_opaque_ap.get())));
+ m_opaque_ap.reset(new SourceManagerImpl (*(rhs.m_opaque_ap.get())));
}
const lldb::SBSourceManager &
SBSourceManager::operator = (const lldb::SBSourceManager &rhs)
{
- m_opaque_ap.reset (new SBSourceManager_impl (*(rhs.m_opaque_ap.get())));
+ m_opaque_ap.reset (new SourceManagerImpl (*(rhs.m_opaque_ap.get())));
return *this;
}
@@ -125,10 +125,10 @@
if (m_opaque_ap.get() == NULL)
return 0;
- return m_opaque_ap->DisplaySourceLinesWithLineNumbers (file,
+ return m_opaque_ap->DisplaySourceLinesWithLineNumbers (file.ref(),
line,
context_before,
context_after,
current_line_cstr,
- s);
+ s.get());
}
Modified: lldb/trunk/source/API/SBTarget.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBTarget.cpp?rev=140930&r1=140929&r2=140930&view=diff
==============================================================================
--- lldb/trunk/source/API/SBTarget.cpp (original)
+++ lldb/trunk/source/API/SBTarget.cpp Fri Sep 30 21:59:24 2011
@@ -499,6 +499,12 @@
return m_opaque_sp.get();
}
+const lldb::TargetSP &
+SBTarget::get_sp () const
+{
+ return m_opaque_sp;
+}
+
void
SBTarget::reset (const lldb::TargetSP& target_sp)
{
More information about the lldb-commits
mailing list