[Lldb-commits] [lldb] r139984 - in /lldb/trunk: include/lldb/Core/Module.h source/API/SBAddress.cpp source/Commands/CommandObjectTarget.cpp source/Core/Address.cpp source/Core/Module.cpp source/Core/SearchFilter.cpp source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp source/Symbol/Symbol.cpp source/Target/StackFrame.cpp
Greg Clayton
gclayton at apple.com
Sat Sep 17 00:23:18 PDT 2011
Author: gclayton
Date: Sat Sep 17 02:23:18 2011
New Revision: 139984
URL: http://llvm.org/viewvc/llvm-project?rev=139984&view=rev
Log:
Removed the function:
ModuleSP
Module::GetSP();
Since we are now using intrusive ref counts, we can easily turn any
pointer to a module into a shared pointer just by assigning it.
Modified:
lldb/trunk/include/lldb/Core/Module.h
lldb/trunk/source/API/SBAddress.cpp
lldb/trunk/source/Commands/CommandObjectTarget.cpp
lldb/trunk/source/Core/Address.cpp
lldb/trunk/source/Core/Module.cpp
lldb/trunk/source/Core/SearchFilter.cpp
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
lldb/trunk/source/Symbol/Symbol.cpp
lldb/trunk/source/Target/StackFrame.cpp
Modified: lldb/trunk/include/lldb/Core/Module.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/Module.h?rev=139984&r1=139983&r2=139984&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Core/Module.h (original)
+++ lldb/trunk/include/lldb/Core/Module.h Sat Sep 17 02:23:18 2011
@@ -103,13 +103,6 @@
~Module ();
//------------------------------------------------------------------
- /// If you have an instance of Module, get its corresponding shared
- /// pointer if it has one in the shared module list.
- //------------------------------------------------------------------
- lldb::ModuleSP
- GetSP () const;
-
- //------------------------------------------------------------------
/// @copydoc SymbolContextScope::CalculateSymbolContext(SymbolContext*)
///
/// @see SymbolContextScope
Modified: lldb/trunk/source/API/SBAddress.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBAddress.cpp?rev=139984&r1=139983&r2=139984&view=diff
==============================================================================
--- lldb/trunk/source/API/SBAddress.cpp (original)
+++ lldb/trunk/source/API/SBAddress.cpp Sat Sep 17 02:23:18 2011
@@ -221,9 +221,9 @@
SBModule sb_module;
if (m_opaque_ap.get())
{
- const Module *module = m_opaque_ap->GetModule();
+ Module *module = m_opaque_ap->GetModule();
if (module)
- *sb_module = module->GetSP();
+ *sb_module = module;
}
return sb_module;
}
Modified: lldb/trunk/source/Commands/CommandObjectTarget.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectTarget.cpp?rev=139984&r1=139983&r2=139984&view=diff
==============================================================================
--- lldb/trunk/source/Commands/CommandObjectTarget.cpp (original)
+++ lldb/trunk/source/Commands/CommandObjectTarget.cpp Sat Sep 17 02:23:18 2011
@@ -2725,7 +2725,7 @@
if (use_global_module_list)
{
module = Module::GetAllocatedModuleAtIndex(image_idx);
- module_sp = module->GetSP();
+ module_sp = module;
}
else
{
Modified: lldb/trunk/source/Core/Address.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/Address.cpp?rev=139984&r1=139983&r2=139984&view=diff
==============================================================================
--- lldb/trunk/source/Core/Address.cpp (original)
+++ lldb/trunk/source/Core/Address.cpp Sat Sep 17 02:23:18 2011
@@ -737,7 +737,7 @@
Module *address_module = m_section->GetModule();
if (address_module)
{
- sc->module_sp = address_module->GetSP();
+ sc->module_sp = address_module;
if (sc->module_sp)
return sc->module_sp->ResolveSymbolContextForAddress (*this, resolve_scope, *sc);
}
@@ -759,7 +759,7 @@
if (m_section)
{
SymbolContext sc;
- sc.module_sp = m_section->GetModule()->GetSP();
+ sc.module_sp = m_section->GetModule();
if (sc.module_sp)
{
sc.module_sp->ResolveSymbolContextForAddress (*this, eSymbolContextCompUnit, sc);
@@ -775,7 +775,7 @@
if (m_section)
{
SymbolContext sc;
- sc.module_sp = m_section->GetModule()->GetSP();
+ sc.module_sp = m_section->GetModule();
if (sc.module_sp)
{
sc.module_sp->ResolveSymbolContextForAddress (*this, eSymbolContextFunction, sc);
@@ -791,7 +791,7 @@
if (m_section)
{
SymbolContext sc;
- sc.module_sp = m_section->GetModule()->GetSP();
+ sc.module_sp = m_section->GetModule();
if (sc.module_sp)
{
sc.module_sp->ResolveSymbolContextForAddress (*this, eSymbolContextBlock, sc);
@@ -807,7 +807,7 @@
if (m_section)
{
SymbolContext sc;
- sc.module_sp = m_section->GetModule()->GetSP();
+ sc.module_sp = m_section->GetModule();
if (sc.module_sp)
{
sc.module_sp->ResolveSymbolContextForAddress (*this, eSymbolContextSymbol, sc);
@@ -823,7 +823,7 @@
if (m_section)
{
SymbolContext sc;
- sc.module_sp = m_section->GetModule()->GetSP();
+ sc.module_sp = m_section->GetModule();
if (sc.module_sp)
{
sc.module_sp->ResolveSymbolContextForAddress (*this, eSymbolContextLineEntry, sc);
Modified: lldb/trunk/source/Core/Module.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/Module.cpp?rev=139984&r1=139983&r2=139984&view=diff
==============================================================================
--- lldb/trunk/source/Core/Module.cpp (original)
+++ lldb/trunk/source/Core/Module.cpp Sat Sep 17 02:23:18 2011
@@ -128,13 +128,6 @@
}
-ModuleSP
-Module::GetSP () const
-{
- ModuleSP module_sp(const_cast<Module*>(this));
- return module_sp;
-}
-
const lldb_private::UUID&
Module::GetUUID()
{
@@ -177,8 +170,8 @@
if (num_comp_units == 0)
return;
- TargetSP null_target;
- SymbolContext sc(null_target, GetSP());
+ SymbolContext sc;
+ sc.module_sp = this;
uint32_t cu_idx;
SymbolVendor *symbols = GetSymbolVendor ();
@@ -212,7 +205,7 @@
void
Module::CalculateSymbolContext(SymbolContext* sc)
{
- sc->module_sp = GetSP();
+ sc->module_sp = this;
}
Module *
@@ -282,7 +275,7 @@
{
// If the section offset based address resolved itself, then this
// is the right module.
- sc.module_sp = GetSP();
+ sc.module_sp = this;
resolved_flags |= eSymbolContextModule;
// Resolve the compile unit, function, block, line table or line
@@ -384,7 +377,7 @@
const uint32_t start_size = sc_list.GetSize();
const uint32_t num_compile_units = GetNumCompileUnits();
SymbolContext sc;
- sc.module_sp = GetSP();
+ sc.module_sp = this;
const bool compare_directory = path.GetDirectory();
for (uint32_t i=0; i<num_compile_units; ++i)
{
Modified: lldb/trunk/source/Core/SearchFilter.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/SearchFilter.cpp?rev=139984&r1=139983&r2=139984&view=diff
==============================================================================
--- lldb/trunk/source/Core/SearchFilter.cpp (original)
+++ lldb/trunk/source/Core/SearchFilter.cpp Sat Sep 17 02:23:18 2011
@@ -401,7 +401,7 @@
Module* module = m_target_sp->GetImages().GetModulePointerAtIndex(i);
if (FileSpec::Compare (m_module_spec, module->GetFileSpec(), false) == 0)
{
- SymbolContext matchingContext(m_target_sp, module->GetSP());
+ SymbolContext matchingContext(m_target_sp, ModuleSP(module));
Searcher::CallbackReturn shouldContinue;
shouldContinue = DoModuleIteration(matchingContext, searcher);
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp?rev=139984&r1=139983&r2=139984&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Sat Sep 17 02:23:18 2011
@@ -1664,7 +1664,7 @@
{
sc.Clear();
// Check if the symbol vendor already knows about this compile unit?
- sc.module_sp = m_obj_file->GetModule()->GetSP();
+ sc.module_sp = m_obj_file->GetModule();
sc.comp_unit = GetCompUnitForDWARFCompUnit(curr_cu, UINT32_MAX);
sc.function = sc.comp_unit->FindFunctionByUID (func_die->GetOffset()).get();
@@ -1969,7 +1969,7 @@
Index ();
SymbolContext sc;
- sc.module_sp = m_obj_file->GetModule()->GetSP();
+ sc.module_sp = m_obj_file->GetModule();
assert (sc.module_sp);
DWARFCompileUnit* dwarf_cu = NULL;
@@ -2018,7 +2018,7 @@
Index ();
SymbolContext sc;
- sc.module_sp = m_obj_file->GetModule()->GetSP();
+ sc.module_sp = m_obj_file->GetModule();
assert (sc.module_sp);
DWARFCompileUnit* dwarf_cu = NULL;
@@ -2057,7 +2057,7 @@
const uint32_t sc_list_initial_size = sc_list.GetSize();
SymbolContext sc;
- sc.module_sp = m_obj_file->GetModule()->GetSP();
+ sc.module_sp = m_obj_file->GetModule();
assert (sc.module_sp);
DWARFCompileUnit* dwarf_cu = NULL;
@@ -2130,7 +2130,7 @@
return;
SymbolContext sc;
- sc.module_sp = m_obj_file->GetModule()->GetSP();
+ sc.module_sp = m_obj_file->GetModule();
assert (sc.module_sp);
DWARFCompileUnit* dwarf_cu = NULL;
@@ -2208,7 +2208,7 @@
return;
SymbolContext sc;
- sc.module_sp = m_obj_file->GetModule()->GetSP();
+ sc.module_sp = m_obj_file->GetModule();
assert (sc.module_sp);
DWARFCompileUnit* dwarf_cu = NULL;
Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp?rev=139984&r1=139983&r2=139984&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp Sat Sep 17 02:23:18 2011
@@ -168,8 +168,7 @@
FileSpec oso_file_spec(oso_symbol->GetMangled().GetName().AsCString(), true);
// Don't allow cached .o files since we dress up each .o file with
// new sections. We want them to be in the module list so we can
- // always find a shared pointer to the module (in Module::GetSP()),
- // but just don't share them.
+ // always find a shared pointer to the module but just don't share them.
const bool always_create = true;
ModuleList::GetSharedModule (oso_file_spec,
m_obj_file->GetModule()->GetArchitecture(),
Modified: lldb/trunk/source/Symbol/Symbol.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Symbol/Symbol.cpp?rev=139984&r1=139983&r2=139984&view=diff
==============================================================================
--- lldb/trunk/source/Symbol/Symbol.cpp (original)
+++ lldb/trunk/source/Symbol/Symbol.cpp Sat Sep 17 02:23:18 2011
@@ -359,7 +359,7 @@
Module *module = range->GetBaseAddress().GetModule ();
if (module)
{
- sc->module_sp = module->GetSP();
+ sc->module_sp = module;
return;
}
}
Modified: lldb/trunk/source/Target/StackFrame.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/StackFrame.cpp?rev=139984&r1=139983&r2=139984&view=diff
==============================================================================
--- lldb/trunk/source/Target/StackFrame.cpp (original)
+++ lldb/trunk/source/Target/StackFrame.cpp Sat Sep 17 02:23:18 2011
@@ -147,7 +147,7 @@
{
if (pc_module)
{
- m_sc.module_sp = pc_module->GetSP();
+ m_sc.module_sp = pc_module;
m_flags.Set (eSymbolContextModule);
}
else
@@ -227,7 +227,7 @@
Module *module = section->GetModule();
if (module)
{
- m_sc.module_sp = module->GetSP();
+ m_sc.module_sp = module;
if (m_sc.module_sp)
m_flags.Set(eSymbolContextModule);
}
More information about the lldb-commits
mailing list