[Lldb-commits] [lldb] r139435 - in /lldb/trunk: include/lldb/Core/DataVisualization.h source/Commands/CommandObjectFrame.cpp source/Commands/CommandObjectType.cpp source/Core/DataVisualization.cpp source/Core/ValueObject.cpp
Enrico Granata
granata.enrico at gmail.com
Fri Sep 9 16:33:15 PDT 2011
Author: enrico
Date: Fri Sep 9 18:33:14 2011
New Revision: 139435
URL: http://llvm.org/viewvc/llvm-project?rev=139435&view=rev
Log:
Renaming a bulk of method calls from Get() to something more descriptive
Modified:
lldb/trunk/include/lldb/Core/DataVisualization.h
lldb/trunk/source/Commands/CommandObjectFrame.cpp
lldb/trunk/source/Commands/CommandObjectType.cpp
lldb/trunk/source/Core/DataVisualization.cpp
lldb/trunk/source/Core/ValueObject.cpp
Modified: lldb/trunk/include/lldb/Core/DataVisualization.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/DataVisualization.h?rev=139435&r1=139434&r2=139435&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Core/DataVisualization.h (original)
+++ lldb/trunk/include/lldb/Core/DataVisualization.h Fri Sep 9 18:33:14 2011
@@ -49,7 +49,7 @@
{
public:
static lldb::ValueFormatSP
- Get (ValueObject& valobj, lldb::DynamicValueType use_dynamic);
+ GetFormat (ValueObject& valobj, lldb::DynamicValueType use_dynamic);
static void
Add (const ConstString &type, const lldb::ValueFormatSP &entry);
@@ -86,7 +86,7 @@
{
public:
static bool
- Get (const ConstString &type, lldb::SummaryFormatSP &entry);
+ GetSummaryFormat (const ConstString &type, lldb::SummaryFormatSP &entry);
static void
Add (const ConstString &type, const lldb::SummaryFormatSP &entry);
@@ -109,7 +109,7 @@
public:
static bool
- Get (const ConstString &category, lldb::FormatCategorySP &entry);
+ GetCategory (const ConstString &category, lldb::FormatCategorySP &entry);
static void
Add (const ConstString &category);
Modified: lldb/trunk/source/Commands/CommandObjectFrame.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectFrame.cpp?rev=139435&r1=139434&r2=139435&view=diff
==============================================================================
--- lldb/trunk/source/Commands/CommandObjectFrame.cpp (original)
+++ lldb/trunk/source/Commands/CommandObjectFrame.cpp Fri Sep 9 18:33:14 2011
@@ -394,7 +394,7 @@
SummaryFormatSP summary_format_sp;
if (!m_option_variable.summary.empty())
- DataVisualization::NamedSummaryFormats::Get(ConstString(m_option_variable.summary.c_str()), summary_format_sp);
+ DataVisualization::NamedSummaryFormats::GetSummaryFormat(ConstString(m_option_variable.summary.c_str()), summary_format_sp);
ValueObject::DumpValueObjectOptions options;
Modified: lldb/trunk/source/Commands/CommandObjectType.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectType.cpp?rev=139435&r1=139434&r2=139435&view=diff
==============================================================================
--- lldb/trunk/source/Commands/CommandObjectType.cpp (original)
+++ lldb/trunk/source/Commands/CommandObjectType.cpp Fri Sep 9 18:33:14 2011
@@ -1049,7 +1049,7 @@
Error* error)
{
lldb::FormatCategorySP category;
- DataVisualization::Categories::Get(ConstString(category_name.c_str()), category);
+ DataVisualization::Categories::GetCategory(ConstString(category_name.c_str()), category);
if (type == eRegexSummary)
{
@@ -1234,7 +1234,7 @@
}
lldb::FormatCategorySP category;
- DataVisualization::Categories::Get(ConstString(m_options.m_category.c_str()), category);
+ DataVisualization::Categories::GetCategory(ConstString(m_options.m_category.c_str()), category);
bool delete_category = category->Delete(typeCS,
eFormatCategoryItemSummary | eFormatCategoryItemRegexSummary);
@@ -1365,10 +1365,10 @@
{
const char* cat_name = command.GetArgumentAtIndex(0);
ConstString cat_nameCS(cat_name);
- DataVisualization::Categories::Get(cat_nameCS, category);
+ DataVisualization::Categories::GetCategory(cat_nameCS, category);
}
else
- DataVisualization::Categories::Get(ConstString(NULL), category);
+ DataVisualization::Categories::GetCategory(ConstString(NULL), category);
category->Clear(eFormatCategoryItemSummary | eFormatCategoryItemRegexSummary);
}
@@ -1667,7 +1667,7 @@
}
DataVisualization::Categories::Enable(typeCS);
lldb::FormatCategorySP cate;
- if (DataVisualization::Categories::Get(typeCS, cate) && cate.get())
+ if (DataVisualization::Categories::GetCategory(typeCS, cate) && cate.get())
{
if (cate->GetCount() == 0)
{
@@ -2462,7 +2462,7 @@
}
lldb::FormatCategorySP category;
- DataVisualization::Categories::Get(ConstString(m_options.m_category.c_str()), category);
+ DataVisualization::Categories::GetCategory(ConstString(m_options.m_category.c_str()), category);
bool delete_category = category->GetFilterNavigator()->Delete(typeCS);
delete_category = category->GetRegexFilterNavigator()->Delete(typeCS) || delete_category;
@@ -2624,7 +2624,7 @@
}
lldb::FormatCategorySP category;
- DataVisualization::Categories::Get(ConstString(m_options.m_category.c_str()), category);
+ DataVisualization::Categories::GetCategory(ConstString(m_options.m_category.c_str()), category);
bool delete_category = category->GetSyntheticNavigator()->Delete(typeCS);
delete_category = category->GetRegexSyntheticNavigator()->Delete(typeCS) || delete_category;
@@ -2757,10 +2757,10 @@
{
const char* cat_name = command.GetArgumentAtIndex(0);
ConstString cat_nameCS(cat_name);
- DataVisualization::Categories::Get(cat_nameCS, category);
+ DataVisualization::Categories::GetCategory(cat_nameCS, category);
}
else
- DataVisualization::Categories::Get(ConstString(NULL), category);
+ DataVisualization::Categories::GetCategory(ConstString(NULL), category);
category->GetFilterNavigator()->Clear();
category->GetRegexFilterNavigator()->Clear();
}
@@ -2883,10 +2883,10 @@
{
const char* cat_name = command.GetArgumentAtIndex(0);
ConstString cat_nameCS(cat_name);
- DataVisualization::Categories::Get(cat_nameCS, category);
+ DataVisualization::Categories::GetCategory(cat_nameCS, category);
}
else
- DataVisualization::Categories::Get(ConstString(NULL), category);
+ DataVisualization::Categories::GetCategory(ConstString(NULL), category);
category->GetSyntheticNavigator()->Clear();
category->GetRegexSyntheticNavigator()->Clear();
}
@@ -3037,7 +3037,7 @@
lldb::FormatCategorySP category;
- DataVisualization::Categories::Get(ConstString(options->m_category.c_str()), category);
+ DataVisualization::Categories::GetCategory(ConstString(options->m_category.c_str()), category);
Error error;
@@ -3156,7 +3156,7 @@
// now I have a valid provider, let's add it to every type
lldb::FormatCategorySP category;
- DataVisualization::Categories::Get(ConstString(m_options.m_category.c_str()), category);
+ DataVisualization::Categories::GetCategory(ConstString(m_options.m_category.c_str()), category);
Error error;
@@ -3215,7 +3215,7 @@
Error* error)
{
lldb::FormatCategorySP category;
- DataVisualization::Categories::Get(ConstString(category_name.c_str()), category);
+ DataVisualization::Categories::GetCategory(ConstString(category_name.c_str()), category);
if (category->AnyMatches(type_name,
eFormatCategoryItemFilter | eFormatCategoryItemRegexFilter,
@@ -3392,7 +3392,7 @@
Error* error)
{
lldb::FormatCategorySP category;
- DataVisualization::Categories::Get(ConstString(category_name.c_str()), category);
+ DataVisualization::Categories::GetCategory(ConstString(category_name.c_str()), category);
if (category->AnyMatches(type_name,
eFormatCategoryItemSynth | eFormatCategoryItemRegexSynth,
@@ -3514,7 +3514,7 @@
// now I have a valid provider, let's add it to every type
lldb::FormatCategorySP category;
- DataVisualization::Categories::Get(ConstString(m_options.m_category.c_str()), category);
+ DataVisualization::Categories::GetCategory(ConstString(m_options.m_category.c_str()), category);
Error error;
Modified: lldb/trunk/source/Core/DataVisualization.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/DataVisualization.cpp?rev=139435&r1=139434&r2=139435&view=diff
==============================================================================
--- lldb/trunk/source/Core/DataVisualization.cpp (original)
+++ lldb/trunk/source/Core/DataVisualization.cpp Fri Sep 9 18:33:14 2011
@@ -39,7 +39,7 @@
}
lldb::ValueFormatSP
-DataVisualization::ValueFormats::Get (ValueObject& valobj, lldb::DynamicValueType use_dynamic)
+DataVisualization::ValueFormats::GetFormat (ValueObject& valobj, lldb::DynamicValueType use_dynamic)
{
lldb::ValueFormatSP entry;
GetFormatManager().GetValueNavigator().Get(valobj, entry, use_dynamic);
@@ -105,7 +105,7 @@
}
bool
-DataVisualization::Categories::Get (const ConstString &category, lldb::FormatCategorySP &entry)
+DataVisualization::Categories::GetCategory (const ConstString &category, lldb::FormatCategorySP &entry)
{
entry = GetFormatManager().GetCategory(category);
return true;
@@ -168,7 +168,7 @@
}
bool
-DataVisualization::NamedSummaryFormats::Get (const ConstString &type, lldb::SummaryFormatSP &entry)
+DataVisualization::NamedSummaryFormats::GetSummaryFormat (const ConstString &type, lldb::SummaryFormatSP &entry)
{
return GetFormatManager().GetNamedSummaryNavigator().Get(type,entry);
}
Modified: lldb/trunk/source/Core/ValueObject.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObject.cpp?rev=139435&r1=139434&r2=139435&view=diff
==============================================================================
--- lldb/trunk/source/Core/ValueObject.cpp (original)
+++ lldb/trunk/source/Core/ValueObject.cpp Fri Sep 9 18:33:14 2011
@@ -248,9 +248,9 @@
if ( (m_last_format_mgr_revision != DataVisualization::GetCurrentRevision()) ||
m_last_format_mgr_dynamic != use_dynamic)
{
- SetValueFormat(DataVisualization::ValueFormats::Get(*this, eNoDynamicValues));
- SetSummaryFormat(DataVisualization::GetSummaryFormat(*this, use_dynamic));
- SetSyntheticChildren(DataVisualization::GetSyntheticChildren(*this, use_dynamic));
+ SetValueFormat(DataVisualization::ValueFormats::GetFormat (*this, eNoDynamicValues));
+ SetSummaryFormat(DataVisualization::GetSummaryFormat (*this, use_dynamic));
+ SetSyntheticChildren(DataVisualization::GetSyntheticChildren (*this, use_dynamic));
m_last_format_mgr_revision = DataVisualization::GetCurrentRevision();
m_last_format_mgr_dynamic = use_dynamic;
More information about the lldb-commits
mailing list