[Lldb-commits] [PATCH] Use isdigit() instead of isnumber(), include cctype

Johnny Chen johnny.chen at apple.com
Fri Aug 19 13:33:42 PDT 2011

Hi Matt,

The workaround which calls isnumber() has been reverted and the isnumber() calls are gone.

On Aug 19, 2011, at 12:15 PM, Matt Johnson wrote:

> DisassemblerLLVM.cpp uses isnumber() to discern whether a character is a decimal digit.  isnumber() is found in BSD and OS X headers, but is not part of the C standard.  isdigit() is the standardized counterpart; I haven't been able to find clear information on what the precise difference is between the two, but my feeling is that we can replace isnumber() with isdigit() with no change in functionality.  The attached patch does so, and includes cctype to make the provenance of the function explicit.
> The practical effect of the patch is to unbreak the build on Linux.
> -Matt
> <isdigit.diff>_______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

More information about the lldb-commits mailing list