[Lldb-commits] [PATCH] Use isdigit() instead of isnumber(), include cctype

Matt Johnson johnso87 at crhc.illinois.edu
Fri Aug 19 12:14:43 PDT 2011


DisassemblerLLVM.cpp uses isnumber() to discern whether a character is a 
decimal digit.  isnumber() is found in BSD and OS X headers, but is not 
part of the C standard.  isdigit() is the standardized counterpart; I 
haven't been able to find clear information on what the precise 
difference is between the two, but my feeling is that we can replace 
isnumber() with isdigit() with no change in functionality.  The attached 
patch does so, and includes cctype to make the provenance of the 
function explicit.

-Matt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: isdigit.diff
Type: text/x-diff
Size: 739 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20110819/9c39b261/attachment.diff>


More information about the lldb-commits mailing list