[Lldb-commits] [lldb] r137699 - /lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp

[Johnny Chen]

Author: johnny
Date: Mon Aug 15 20:16:02 2011
New Revision: 137699

URL: http://llvm.org/viewvc/llvm-project?rev=137699&view=rev
Log:
Fix two logic errors uncovered by the static analyzer.

For the default case (illegal encoding type), just return false instead of break.

A8.6.84 LDRSH (register)
A8.6.309 VLD1 (single element to all lanes)

Modified:
    lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp

Modified: lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp?rev=137699&r1=137698&r2=137699&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp (original)
+++ lldb/trunk/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp Mon Aug 15 20:16:02 2011
@@ -7657,7 +7657,7 @@
                 break;
                   
             default:
-                break;
+                return false;
         }
                   
         uint64_t Rm = ReadRegisterUnsigned (eRegisterKindDWARF, dwarf_r0 + m, 0, &success);
@@ -11960,10 +11960,10 @@
                 if (n == 15)
                     return false;
             }
-                break;
+            break;
                 
             default:
-                break;
+                return false;
         }
         
         RegisterInfo base_reg;