[Lldb-commits] [lldb] r134598 - in /lldb/trunk: include/lldb/Core/RegularExpression.h source/Commands/CommandObjectTarget.cpp source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

Greg Clayton gclayton at apple.com
Wed Jul 6 21:49:07 PDT 2011


Author: gclayton
Date: Wed Jul  6 23:49:07 2011
New Revision: 134598

URL: http://llvm.org/viewvc/llvm-project?rev=134598&view=rev
Log:
Stop the lldb_private::RegularExpression class from implicitly
constructing itself and causing unexpected things to happen
in LLDB.


Modified:
    lldb/trunk/include/lldb/Core/RegularExpression.h
    lldb/trunk/source/Commands/CommandObjectTarget.cpp
    lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

Modified: lldb/trunk/include/lldb/Core/RegularExpression.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Core/RegularExpression.h?rev=134598&r1=134597&r2=134598&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Core/RegularExpression.h (original)
+++ lldb/trunk/include/lldb/Core/RegularExpression.h Wed Jul  6 23:49:07 2011
@@ -51,6 +51,7 @@
     /// @param[in] flags
     ///     Flags that are passed the the \c regcomp() function.
     //------------------------------------------------------------------
+    explicit
     RegularExpression (const char* re, int flags = REG_EXTENDED);
 
     //------------------------------------------------------------------

Modified: lldb/trunk/source/Commands/CommandObjectTarget.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectTarget.cpp?rev=134598&r1=134597&r2=134598&view=diff
==============================================================================
--- lldb/trunk/source/Commands/CommandObjectTarget.cpp (original)
+++ lldb/trunk/source/Commands/CommandObjectTarget.cpp Wed Jul  6 23:49:07 2011
@@ -465,7 +465,7 @@
                     }
                     else
                     {
-                        matches = exe_ctx.target->GetImages().FindGlobalVariables (arg,
+                        matches = exe_ctx.target->GetImages().FindGlobalVariables (ConstString(arg),
                                                                                    true, 
                                                                                    UINT32_MAX, 
                                                                                    global_var_list);

Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp?rev=134598&r1=134597&r2=134598&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Wed Jul  6 23:49:07 2011
@@ -4428,7 +4428,7 @@
     
     std::vector<NameToDIE::Info> die_info_array;
     
-    size_t num_matches = m_type_index.Find (name, die_info_array);
+    size_t num_matches = m_type_index.Find (ConstString(name), die_info_array);
     
     if (num_matches)
     {





More information about the lldb-commits mailing list