[Lldb-commits] [PATCH] Support for running test suite using makefiles on Linux

[Charles Davis]

On 6/18/11 6:32 PM, Peter Collingbourne wrote:
[From patch 1]
> @@ -31,15 +36,27 @@ endif
[...]
> +ifeq "$(DYLIB_NAME)" ""
You do mean "ifneq" here, right? Otherwise, you'll get back lib.so (or
lib.dylib) as the shared library's filename. :)

[From patch 4]
> @@ -35,21 +35,23 @@ LLDB_SWIG_INCLUDE_DIRS += -I"/usr/include"
>  LLDBWrapPython.cpp:
[...]
> +	$(Verb) $(RM) -f $(PYTHON_DIR)/_lldb.so
> +	$(Verb) $(AliasTool) $(LIBLLDB) $(PYTHON_DIR)/_lldb.so
This can't work. At least, it can't if the $(AliasTool) expects the
source file to exist. At first, I thought you'd need to depend on
liblldb.so; but that won't work either, because liblldb.so depends on
LLDBWrapPython.cpp! You'll have to make the _lldb.so symlink elsewhere.

Otherwise, looks fine. I would test on my Mac, but I already know it
won't work because of patch 4.

Chip