[Lldb-commits] [lldb] r132072 - in /lldb/trunk/test: lldbtest.py lldbutil.py

Johnny Chen johnny.chen at apple.com
Wed May 25 12:06:18 PDT 2011


Author: johnny
Date: Wed May 25 14:06:18 2011
New Revision: 132072

URL: http://llvm.org/viewvc/llvm-project?rev=132072&view=rev
Log:
Convert these two modules to use the compact truth value testing as well.

Modified:
    lldb/trunk/test/lldbtest.py
    lldb/trunk/test/lldbutil.py

Modified: lldb/trunk/test/lldbtest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lldbtest.py?rev=132072&r1=132071&r2=132072&view=diff
==============================================================================
--- lldb/trunk/test/lldbtest.py (original)
+++ lldb/trunk/test/lldbtest.py Wed May 25 14:06:18 2011
@@ -522,7 +522,7 @@
         except AttributeError:
             self.dbg = lldb.SBDebugger.Create()
 
-        if not self.dbg.IsValid():
+        if not self.dbg:
             raise Exception('Invalid debugger instance')
 
         # We want our debugger to be synchronous.
@@ -715,7 +715,7 @@
         # Terminate the current process being debugged, if any.
         if self.runStarted:
             self.runCmd("process kill", PROCESS_KILLED, check=False)
-        elif self.process and self.process.IsValid():
+        elif self.process:
             rc = self.invoke(self.process, "Kill")
             self.assertTrue(rc.Success(), PROCESS_KILLED)
             del self.process

Modified: lldb/trunk/test/lldbutil.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lldbutil.py?rev=132072&r1=132071&r2=132072&view=diff
==============================================================================
--- lldb/trunk/test/lldbutil.py (original)
+++ lldb/trunk/test/lldbutil.py Wed May 25 14:06:18 2011
@@ -382,7 +382,7 @@
         function = frame.GetFunction()
 
         load_addr = addrs[i].GetLoadAddress(target)
-        if not function.IsValid():
+        if not function:
             file_addr = addrs[i].GetFileAddress()
             print >> output, "  frame #{num}: {addr:#016x} {mod}`{symbol} + ????".format(
                 num=i, addr=load_addr, mod=mods[i], symbol=symbols[i])
@@ -440,9 +440,9 @@
         args.append("(%s)%s=%s" % (var.GetTypeName(),
                                    var.GetName(),
                                    var.GetValue(frame)))
-    if frame.GetFunction().IsValid():
+    if frame.GetFunction():
         name = frame.GetFunction().GetName()
-    elif frame.GetSymbol().IsValid():
+    elif frame.GetSymbol():
         name = frame.GetSymbol().GetName()
     else:
         name = ""





More information about the lldb-commits mailing list