[Lldb-commits] [PATCH] Removing FindProcessesByName.

Greg Clayton gclayton at apple.com
Wed Apr 6 11:55:27 PDT 2011


This has been changed to use the new FindProcesses which is in the host layer:

    static uint32_t
    FindProcesses (const ProcessInfoMatch &match_info,
                   ProcessInfoList &proc_infos);
    


I have submitted what I think fixes the issue, though I don't have a linux box to test:

% svn commit
Sending        Linux/PlatformLinux.cpp
Sending        Linux/PlatformLinux.h
Transmitting file data ..
Committed revision 129018.


On Apr 6, 2011, at 8:32 AM, Marco Minutoli wrote:

> Hello everybody,
> 
> at the moment the build on linux is broken by the missing method
> Host::FindProcessesByName. Stephen told me that it was removed some
> time ago so I wrote this little patch to remove the method that coused
> the problem.
> 
> Best regards,
> Marco
> 
> ---
> source/Plugins/Platform/Linux/PlatformLinux.cpp |    8 --------
> source/Plugins/Platform/Linux/PlatformLinux.h   |    5 -----
> 2 files changed, 0 insertions(+), 13 deletions(-)
> 
> diff --git a/source/Plugins/Platform/Linux/PlatformLinux.cpp b/source/Plugins/Platform/Linux/PlatformLinux.cpp
> index c5200d2..379a08e 100644
> --- a/source/Plugins/Platform/Linux/PlatformLinux.cpp
> +++ b/source/Plugins/Platform/Linux/PlatformLinux.cpp
> @@ -191,14 +191,6 @@ PlatformLinux::~PlatformLinux()
> {
> }
> 
> -uint32_t
> -PlatformLinux::FindProcessesByName (const char *name_match, 
> -                                    NameMatchType name_match_type,
> -                                    ProcessInfoList &process_infos)
> -{
> -    return Host::FindProcessesByName (name_match, name_match_type, process_infos);
> -}
> -
> bool
> PlatformLinux::GetProcessInfo (lldb::pid_t pid, ProcessInfo &process_info)
> {
> diff --git a/source/Plugins/Platform/Linux/PlatformLinux.h b/source/Plugins/Platform/Linux/PlatformLinux.h
> index 395778b..bb9f62c 100644
> --- a/source/Plugins/Platform/Linux/PlatformLinux.h
> +++ b/source/Plugins/Platform/Linux/PlatformLinux.h
> @@ -84,11 +84,6 @@ namespace lldb_private {
>         GetFile (const FileSpec &platform_file,
>                  const UUID* uuid, FileSpec &local_file);
> 
> -        virtual uint32_t
> -        FindProcessesByName (const char *name_match, 
> -                             NameMatchType name_match_type,
> -                             ProcessInfoList &process_infos);
> -
>         virtual bool
>         GetProcessInfo (lldb::pid_t pid, ProcessInfo &proc_info);
> 
> -- 
> 1.7.1
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits




More information about the lldb-commits mailing list