[Lldb-commits] [PATCH] give subclasses access to UnixSignals::m_signals

Stephen Wilson wilsons at start.ca
Tue Mar 29 17:26:21 PDT 2011


Any chance I could get a quick thumbs up on the following patch?

I know this is a rater trivial change and I should probably just go
ahead and commit it.  My main concern was if there are any short-term
plans to move the default darwin-specific implementation elsewhere --
thus potentially making this change redundant. 


On Sun, Mar 27, 2011 at 08:38:24PM -0400, Stephen Wilson wrote:
> 
> Allow subclasses of UnixSignals to access m_signals by marking the
> member protected instead of private.  This enables a subclass to provide
> a default signal set as appropriate on construction.
> 
> 
> 
> diff --git a/include/lldb/Target/UnixSignals.h b/include/lldb/Target/UnixSignals.h
> index 3e13438..f47a90b 100644
> --- a/include/lldb/Target/UnixSignals.h
> +++ b/include/lldb/Target/UnixSignals.h
> @@ -133,10 +133,6 @@ protected:
>      void
>      Reset ();
>  
> -private:
> -    //------------------------------------------------------------------
> -    // For UnixSignals only
> -    //------------------------------------------------------------------
>      typedef std::map <int32_t, Signal> collection;
>  
>      collection m_signals;
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

-- 
steve




More information about the lldb-commits mailing list