[Lldb-commits] [lldb] r127194 - in /lldb/trunk: include/lldb/Symbol/ObjectFile.h source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.h source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h source/Target/ThreadPlanCallFunction.cpp

[Stephen Wilson]

Hi Jim,

On Mon, Mar 07, 2011 at 11:44:08PM -0000, Jim Ingham wrote:
> Author: jingham
> Date: Mon Mar  7 17:44:08 2011
> New Revision: 127194
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=127194&view=rev
> Log:
>
> Add a method "GetEntryPoint" to the ObjectFile class, and implement it
> on MachO & ELF - though the ELF implementation is probably a little
> weak.  Then use this method in place of directly looking for "start"
> in the ThreadPlanCallFunction constructor to find the stopping point
> for our function evaluation.


I think we need to use the existing ObjectFile::GetEntryPoint here?  ELF
already has an implementation in r123496 (done as part of the linux
dynamic plugin work).

I guess this was just overlooked as I did not implement support on the
MachO side, right?


-- 
steve