[Lldb-commits] [PATCH 4/4] linux: Use ArchSpec::GetCore and the ArchSpec::Core enums.

Greg Clayton gclayton at apple.com
Wed Feb 23 15:58:30 PST 2011


Looks good.

On Feb 23, 2011, at 1:16 PM, Stephen Wilson wrote:

> ---
> source/Plugins/Process/Linux/LinuxThread.cpp  |    4 ++--
> source/Plugins/Process/Linux/ProcessLinux.cpp |    6 +++---
> 2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/source/Plugins/Process/Linux/LinuxThread.cpp b/source/Plugins/Process/Linux/LinuxThread.cpp
> index 5c278d4..397d31b 100644
> --- a/source/Plugins/Process/Linux/LinuxThread.cpp
> +++ b/source/Plugins/Process/Linux/LinuxThread.cpp
> @@ -65,13 +65,13 @@ LinuxThread::GetRegisterContext()
>     {
>         ArchSpec arch = process.GetTarget().GetArchitecture();
> 
> -        switch (arch.GetGenericCPUType())
> +        switch (arch.GetCore())
>         {
>         default:
>             assert(false && "CPU type not supported!");
>             break;
> 
> -        case ArchSpec::eCPU_x86_64:
> +        case ArchSpec::eCore_x86_64_x86_64:
>             m_reg_context_sp.reset(new RegisterContextLinux_x86_64(*this, 0));
>             break;
>         }
> diff --git a/source/Plugins/Process/Linux/ProcessLinux.cpp b/source/Plugins/Process/Linux/ProcessLinux.cpp
> index 9939fe7..f62a303 100644
> --- a/source/Plugins/Process/Linux/ProcessLinux.cpp
> +++ b/source/Plugins/Process/Linux/ProcessLinux.cpp
> @@ -353,14 +353,14 @@ ProcessLinux::GetSoftwareBreakpointTrapOpcode(BreakpointSite* bp_site)
>     const uint8_t *opcode = NULL;
>     size_t opcode_size = 0;
> 
> -    switch (arch.GetGenericCPUType())
> +    switch (arch.GetCore())
>     {
>     default:
>         assert(false && "CPU type not supported!");
>         break;
> 
> -    case ArchSpec::eCPU_i386:
> -    case ArchSpec::eCPU_x86_64:
> +    case ArchSpec::eCore_x86_32_i386:
> +    case ArchSpec::eCore_x86_64_x86_64:
>         opcode = g_i386_opcode;
>         opcode_size = sizeof(g_i386_opcode);
>         break;
> -- 
> 1.7.3.5
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits





More information about the lldb-commits mailing list