[Lldb-commits] [lldb] r123465 - /lldb/trunk/source/Target/Process.cpp

Stephen Wilson wilsons at start.ca
Fri Jan 14 13:07:56 PST 2011


Author: wilsons
Date: Fri Jan 14 15:07:56 2011
New Revision: 123465

URL: http://llvm.org/viewvc/llvm-project?rev=123465&view=rev
Log:
Do not prematurely invalidate thread handle.

Setting m_private_state_thread to an invalid value when the child thread exits
results in a race condition between calls to ThreadCancel and ThreadJoin.


Modified:
    lldb/trunk/source/Target/Process.cpp

Modified: lldb/trunk/source/Target/Process.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Target/Process.cpp?rev=123465&r1=123464&r2=123465&view=diff
==============================================================================
--- lldb/trunk/source/Target/Process.cpp (original)
+++ lldb/trunk/source/Target/Process.cpp Fri Jan 14 15:07:56 2011
@@ -2173,7 +2173,6 @@
     if (log)
         log->Printf ("Process::%s (arg = %p, pid = %i) thread exiting...", __FUNCTION__, this, GetID());
 
-    m_private_state_thread = LLDB_INVALID_HOST_THREAD;
     return NULL;
 }
 





More information about the lldb-commits mailing list