[Lldb-commits] [lldb] r123181 - in /lldb/trunk/test/python_api/frame: TestFrames.py main.c

Johnny Chen johnny.chen at apple.com
Mon Jan 10 09:44:09 PST 2011


Author: johnny
Date: Mon Jan 10 11:44:08 2011
New Revision: 123181

URL: http://llvm.org/viewvc/llvm-project?rev=123181&view=rev
Log:
Fix wrong test case in main.c.  Oops!

Modified:
    lldb/trunk/test/python_api/frame/TestFrames.py
    lldb/trunk/test/python_api/frame/main.c

Modified: lldb/trunk/test/python_api/frame/TestFrames.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/python_api/frame/TestFrames.py?rev=123181&r1=123180&r2=123181&view=diff
==============================================================================
--- lldb/trunk/test/python_api/frame/TestFrames.py (original)
+++ lldb/trunk/test/python_api/frame/TestFrames.py Mon Jan 10 11:44:08 2011
@@ -12,7 +12,6 @@
 
     mydir = os.path.join("python_api", "frame")
 
-    @unittest2.expectedFailure
     @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin")
     @python_api_test
     def test_get_arg_vals_for_call_stack_with_dsym(self):
@@ -20,7 +19,6 @@
         self.buildDsym()
         self.do_get_arg_vals()
 
-    @unittest2.expectedFailure
     @python_api_test
     def test_get_arg_vals_for_call_stack_with_dwarf(self):
         """Exercise SBFrame.GetVariables() API to get argument vals."""
@@ -103,8 +101,6 @@
         #     o a((int)val=3, (char)ch='A')
         print "Full stack traces when stopped on the breakpoint 'c':"
         print session.getvalue()
-        # rdar://problem/8801262
-        # test failure: ./dotest.py -v -w -t -p TestFrames (argument values are wrong)
         self.expect(session.getvalue(), "Argugment values displayed correctly",
                     exe=False,
             substrs = ["a((int)val=1, (char)ch='A')",

Modified: lldb/trunk/test/python_api/frame/main.c
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/python_api/frame/main.c?rev=123181&r1=123180&r2=123181&view=diff
==============================================================================
--- lldb/trunk/test/python_api/frame/main.c (original)
+++ lldb/trunk/test/python_api/frame/main.c Mon Jan 10 11:44:08 2011
@@ -20,9 +20,9 @@
     char my_ch = ch;
     printf("a(val=%d, ch='%c')\n", val, ch);
     if (val <= 1)
-        return b(++val, ++ch);
+        return b(val+1, ch+1);
     else if (val >= 3)
-        return c(++val, ++ch);
+        return c(val+1, ch+1);
 
     return val;
 }
@@ -32,7 +32,7 @@
     int my_val = val;
     char my_ch = ch;
     printf("b(val=%d, ch='%c')\n", val, ch);
-    return c(++val, ++ch);
+    return c(val+1, ch+1);
 }
 
 int c(int val, char ch)





More information about the lldb-commits mailing list