[Lldb-commits] [lldb] r122837 - in /lldb/trunk/source/Plugins/Process/Linux: ProcessLinux.cpp ProcessLinux.h

[Stephen Wilson]

Author: wilsons
Date: Tue Jan  4 15:42:31 2011
New Revision: 122837

URL: http://llvm.org/viewvc/llvm-project?rev=122837&view=rev
Log:
Do not load sections manually when launching a Linux process.

This code was a temporary workaround due to the lack of a dynamic loader plugin
for the Linux platform that has bit rotted over time.  Instead of replacing this
hack with another a proper plugin will be developed instead.


Modified:
    lldb/trunk/source/Plugins/Process/Linux/ProcessLinux.cpp
    lldb/trunk/source/Plugins/Process/Linux/ProcessLinux.h

Modified: lldb/trunk/source/Plugins/Process/Linux/ProcessLinux.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Linux/ProcessLinux.cpp?rev=122837&r1=122836&r2=122837&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/Linux/ProcessLinux.cpp (original)
+++ lldb/trunk/source/Plugins/Process/Linux/ProcessLinux.cpp Tue Jan  4 15:42:31 2011
@@ -127,12 +127,6 @@
     return error;
 }
 
-void
-ProcessLinux::DidLaunch()
-{
-    UpdateLoadedSections();
-}
-
 Error
 ProcessLinux::DoResume()
 {
@@ -404,27 +398,6 @@
 //------------------------------------------------------------------------------
 // Utility functions.
 
-void
-ProcessLinux::UpdateLoadedSections()
-{
-    ObjectFile *obj_file = m_module->GetObjectFile();
-    SectionList *sections = obj_file->GetSectionList();
-
-    // FIXME: SectionList provides iterator types, but no begin/end methods.
-    size_t num_sections = sections->GetSize();
-    for (unsigned i = 0; i < num_sections; ++i)
-    {
-        Section *section = sections->GetSectionAtIndex(i).get();
-
-        lldb::addr_t new_load_addr = section->GetFileAddress();
-        lldb::addr_t old_load_addr = GetSectionLoadAddress(section);
-
-        if (old_load_addr == LLDB_INVALID_ADDRESS ||
-            old_load_addr != new_load_addr)
-            SectionLoaded(section, new_load_addr);
-    }
-}
-
 bool
 ProcessLinux::HasExited()
 {

Modified: lldb/trunk/source/Plugins/Process/Linux/ProcessLinux.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Linux/ProcessLinux.h?rev=122837&r1=122836&r2=122837&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/Linux/ProcessLinux.h (original)
+++ lldb/trunk/source/Plugins/Process/Linux/ProcessLinux.h Tue Jan  4 15:42:31 2011
@@ -71,9 +71,6 @@
              const char *stdout_path,
              const char *stderr_path);
 
-    virtual void
-    DidLaunch();
-
     virtual lldb_private::Error
     DoResume();