[Lldb-commits] [PATCH 4/9] Do not load sections manually when launching a Linux process.

Stephen Wilson wilsons at start.ca
Tue Jan 4 12:54:12 PST 2011


This code was a temporary workaround due to the lack of a dynamic loader plugin
for the Linux platform that has bit rotted over time.  Instead of replacing this
hack with another a proper plugin will be developed instead.
---
 source/Plugins/Process/Linux/ProcessLinux.cpp |   27 -------------------------
 source/Plugins/Process/Linux/ProcessLinux.h   |    3 --
 2 files changed, 0 insertions(+), 30 deletions(-)

diff --git a/source/Plugins/Process/Linux/ProcessLinux.cpp b/source/Plugins/Process/Linux/ProcessLinux.cpp
index 6d7b5cf..acaff50 100644
--- a/source/Plugins/Process/Linux/ProcessLinux.cpp
+++ b/source/Plugins/Process/Linux/ProcessLinux.cpp
@@ -127,12 +127,6 @@ ProcessLinux::DoLaunch(Module *module,
     return error;
 }
 
-void
-ProcessLinux::DidLaunch()
-{
-    UpdateLoadedSections();
-}
-
 Error
 ProcessLinux::DoResume()
 {
@@ -404,27 +398,6 @@ ProcessLinux::EnablePluginLogging(Stream *strm, Args &command)
 //------------------------------------------------------------------------------
 // Utility functions.
 
-void
-ProcessLinux::UpdateLoadedSections()
-{
-    ObjectFile *obj_file = m_module->GetObjectFile();
-    SectionList *sections = obj_file->GetSectionList();
-
-    // FIXME: SectionList provides iterator types, but no begin/end methods.
-    size_t num_sections = sections->GetSize();
-    for (unsigned i = 0; i < num_sections; ++i)
-    {
-        Section *section = sections->GetSectionAtIndex(i).get();
-
-        lldb::addr_t new_load_addr = section->GetFileAddress();
-        lldb::addr_t old_load_addr = GetSectionLoadAddress(section);
-
-        if (old_load_addr == LLDB_INVALID_ADDRESS ||
-            old_load_addr != new_load_addr)
-            SectionLoaded(section, new_load_addr);
-    }
-}
-
 bool
 ProcessLinux::HasExited()
 {
diff --git a/source/Plugins/Process/Linux/ProcessLinux.h b/source/Plugins/Process/Linux/ProcessLinux.h
index 536dd9b..16c2bec 100644
--- a/source/Plugins/Process/Linux/ProcessLinux.h
+++ b/source/Plugins/Process/Linux/ProcessLinux.h
@@ -71,9 +71,6 @@ public:
              const char *stdout_path,
              const char *stderr_path);
 
-    virtual void
-    DidLaunch();
-
     virtual lldb_private::Error
     DoResume();
 
-- 
1.7.3.2




More information about the lldb-commits mailing list