[Lldb-commits] [PATCH] linux: fix Host definitions

Stephen Wilson wilsons at start.ca
Wed Dec 15 10:37:16 PST 2010

Hi all,

This is the first patch in a series I plan on sending to get the Linux
build back on its feet.

I have roughly 25 patches to send out and would very much appreciate
some review before they go into the tree.  I think I still have commit
access and would be happy to commit them myself if desired.

Fix definitions of Host::LaunchInNewTerminal and Host::OpenFileInExternalEditor.
Definitions did not agree with the corresponding declarations when
compiling on non-Apple platforms.

diff --git a/source/Host/common/Host.cpp b/source/Host/common/Host.cpp
index 527d20a..c760aa3 100644
--- a/source/Host/common/Host.cpp
+++ b/source/Host/common/Host.cpp
@@ -877,7 +877,7 @@ Host::GetArchSpecForExistingProcess (const char *process_name)
 #if !defined (__APPLE__) // see macosx/Host.mm
-Host::OpenFileInExternalEditor (FileSpec &file_spec, uint32_t line_no)
+Host::OpenFileInExternalEditor (const FileSpec &file_spec, uint32_t line_no)
     return false;
@@ -901,6 +901,7 @@ LaunchApplication (const FileSpec &app_file_spec)
+    const char *tty_name,
     const char **argv, 
     const char **envp,
     const ArchSpec *arch_spec,

More information about the lldb-commits mailing list