[Lldb-commits] [lldb] r121220 - in /lldb/trunk/test: array_types/TestArrayTypes.py bitfields/TestBitfields.py class_static/TestStaticVariables.py class_types/TestClassTypes.py conditional_break/TestConditionalBreak.py dotest.py foundation/TestSymbolTable.py hello_world/TestHelloWorld.py lldbtest.py threads/TestPrintStackTraces.py

Johnny Chen johnny.chen at apple.com
Tue Dec 7 17:25:21 PST 2010


Author: johnny
Date: Tue Dec  7 19:25:21 2010
New Revision: 121220

URL: http://llvm.org/viewvc/llvm-project?rev=121220&view=rev
Log:
For SBTarget.Launch()/LaunchProcess(), there's no need to pass an empty string
as the args and the envs to the launched process.

o lldbtest.py:

  Forgot to check in some assertion messages changes for lldbtest.py.

o dotest.py:

  Also add "api" category to the default lldb log option list.

Modified:
    lldb/trunk/test/array_types/TestArrayTypes.py
    lldb/trunk/test/bitfields/TestBitfields.py
    lldb/trunk/test/class_static/TestStaticVariables.py
    lldb/trunk/test/class_types/TestClassTypes.py
    lldb/trunk/test/conditional_break/TestConditionalBreak.py
    lldb/trunk/test/dotest.py
    lldb/trunk/test/foundation/TestSymbolTable.py
    lldb/trunk/test/hello_world/TestHelloWorld.py
    lldb/trunk/test/lldbtest.py
    lldb/trunk/test/threads/TestPrintStackTraces.py

Modified: lldb/trunk/test/array_types/TestArrayTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/array_types/TestArrayTypes.py?rev=121220&r1=121219&r2=121220&view=diff
==============================================================================
--- lldb/trunk/test/array_types/TestArrayTypes.py (original)
+++ lldb/trunk/test/array_types/TestArrayTypes.py Tue Dec  7 19:25:21 2010
@@ -108,7 +108,7 @@
             substrs = ["resolved = 1"])
 
         # Now launch the process, and do not stop at entry point.
-        self.process = target.LaunchProcess([''], [''], os.ctermid(), 0, False)
+        self.process = target.LaunchProcess([], [], os.ctermid(), 0, False)
 
         self.process = target.GetProcess()
         self.assertTrue(self.process.IsValid(), PROCESS_IS_VALID)

Modified: lldb/trunk/test/bitfields/TestBitfields.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/bitfields/TestBitfields.py?rev=121220&r1=121219&r2=121220&view=diff
==============================================================================
--- lldb/trunk/test/bitfields/TestBitfields.py (original)
+++ lldb/trunk/test/bitfields/TestBitfields.py Tue Dec  7 19:25:21 2010
@@ -94,7 +94,7 @@
 
         self.runCmd("run", RUN_SUCCEEDED, setCookie=False)
         # This does not work, and results in the process stopped at dyld_start?
-        #process = target.LaunchProcess([''], [''], os.ctermid(), False)
+        #process = target.LaunchProcess([], [], os.ctermid(), False)
 
         self.process = target.GetProcess()
         self.assertTrue(self.process.IsValid(), PROCESS_IS_VALID)

Modified: lldb/trunk/test/class_static/TestStaticVariables.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/class_static/TestStaticVariables.py?rev=121220&r1=121219&r2=121220&view=diff
==============================================================================
--- lldb/trunk/test/class_static/TestStaticVariables.py (original)
+++ lldb/trunk/test/class_static/TestStaticVariables.py Tue Dec  7 19:25:21 2010
@@ -78,7 +78,7 @@
         self.assertTrue(breakpoint.IsValid(), VALID_BREAKPOINT)
 
         # Now launch the process, and do not stop at entry point.
-        self.process = target.LaunchProcess([''], [''], os.ctermid(), 0, False)
+        self.process = target.LaunchProcess([], [], os.ctermid(), 0, False)
 
         self.process = target.GetProcess()
         self.assertTrue(self.process.IsValid(), PROCESS_IS_VALID)

Modified: lldb/trunk/test/class_types/TestClassTypes.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/class_types/TestClassTypes.py?rev=121220&r1=121219&r2=121220&view=diff
==============================================================================
--- lldb/trunk/test/class_types/TestClassTypes.py (original)
+++ lldb/trunk/test/class_types/TestClassTypes.py Tue Dec  7 19:25:21 2010
@@ -118,7 +118,7 @@
 
         # Now launch the process, and do not stop at entry point.
         rc = lldb.SBError()
-        self.process = target.Launch([''], [''], os.ctermid(), 0, False, rc)
+        self.process = target.Launch([], [], os.ctermid(), 0, False, rc)
         #self.breakAfterLaunch(self.process, "C::C(int, int, int)")
 
         if not rc.Success() or not self.process.IsValid():

Modified: lldb/trunk/test/conditional_break/TestConditionalBreak.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/conditional_break/TestConditionalBreak.py?rev=121220&r1=121219&r2=121220&view=diff
==============================================================================
--- lldb/trunk/test/conditional_break/TestConditionalBreak.py (original)
+++ lldb/trunk/test/conditional_break/TestConditionalBreak.py Tue Dec  7 19:25:21 2010
@@ -51,7 +51,7 @@
 
         # Now launch the process, and do not stop at entry point.
         rc = lldb.SBError()
-        self.process = target.Launch([''], [''], os.ctermid(), 0, False, rc)
+        self.process = target.Launch([], [], os.ctermid(), 0, False, rc)
 
         self.assertTrue(rc.Success() and self.process.IsValid(), PROCESS_IS_VALID)
 

Modified: lldb/trunk/test/dotest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/dotest.py?rev=121220&r1=121219&r2=121220&view=diff
==============================================================================
--- lldb/trunk/test/dotest.py (original)
+++ lldb/trunk/test/dotest.py Tue Dec  7 19:25:21 2010
@@ -557,7 +557,7 @@
         if ("LLDB_LOG_OPTION" in os.environ):
             lldb_log_option = os.environ["LLDB_LOG_OPTION"]
         else:
-            lldb_log_option = "event process expr state"
+            lldb_log_option = "event process expr state api"
         ci.HandleCommand(
             "log enable -T -n -f " + os.environ["LLDB_LOG"] + " lldb " + lldb_log_option,
             res)

Modified: lldb/trunk/test/foundation/TestSymbolTable.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/foundation/TestSymbolTable.py?rev=121220&r1=121219&r2=121220&view=diff
==============================================================================
--- lldb/trunk/test/foundation/TestSymbolTable.py (original)
+++ lldb/trunk/test/foundation/TestSymbolTable.py Tue Dec  7 19:25:21 2010
@@ -43,7 +43,7 @@
         self.assertTrue(target.IsValid(), VALID_TARGET)
 
         # Launch the process, and do not stop at the entry point.
-        process = target.LaunchProcess([''], [''], os.ctermid(), 0, False)
+        process = target.LaunchProcess([], [], os.ctermid(), 0, False)
 
         #
         # Exercise Python APIs to access the symbol table entries.

Modified: lldb/trunk/test/hello_world/TestHelloWorld.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/hello_world/TestHelloWorld.py?rev=121220&r1=121219&r2=121220&view=diff
==============================================================================
--- lldb/trunk/test/hello_world/TestHelloWorld.py (original)
+++ lldb/trunk/test/hello_world/TestHelloWorld.py Tue Dec  7 19:25:21 2010
@@ -51,7 +51,7 @@
         # SBTarget.LaunchProcess() issue (or is there some race condition)?
 
         if useLaunchAPI:
-            process = target.LaunchProcess([''], [''], os.ctermid(), 0, False)
+            process = target.LaunchProcess([], [], os.ctermid(), 0, False)
             # The following isn't needed anymore, rdar://8364687 is fixed.
             #
             # Apply some dances after LaunchProcess() in order to break at "main".

Modified: lldb/trunk/test/lldbtest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lldbtest.py?rev=121220&r1=121219&r2=121220&view=diff
==============================================================================
--- lldb/trunk/test/lldbtest.py (original)
+++ lldb/trunk/test/lldbtest.py Tue Dec  7 19:25:21 2010
@@ -174,8 +174,12 @@
 
 VALID_FILESPEC = "Got a valid filespec"
 
+VALID_MODULE = "Got a valid module"
+
 VALID_PROCESS = "Got a valid process"
 
+VALID_SYMBOL = "Got a valid symbol"
+
 VALID_TARGET = "Got a valid target"
 
 VARIABLES_DISPLAYED_CORRECTLY = "Variable(s) displayed correctly"

Modified: lldb/trunk/test/threads/TestPrintStackTraces.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/threads/TestPrintStackTraces.py?rev=121220&r1=121219&r2=121220&view=diff
==============================================================================
--- lldb/trunk/test/threads/TestPrintStackTraces.py (original)
+++ lldb/trunk/test/threads/TestPrintStackTraces.py Tue Dec  7 19:25:21 2010
@@ -35,7 +35,7 @@
 
         # Now launch the process, and do not stop at entry point.
         rc = lldb.SBError()
-        self.process = target.Launch([''], [''], os.ctermid(), 0, False, rc)
+        self.process = target.Launch([], [], os.ctermid(), 0, False, rc)
 
         if not rc.Success() or not self.process.IsValid():
             self.fail("SBTarget.LaunchProcess() failed")





More information about the lldb-commits mailing list