[Lldb-commits] [lldb] r119750 - /lldb/trunk/source/Expression/IRForTarget.cpp

[Sean Callanan]

Author: spyffe
Date: Thu Nov 18 16:21:58 2010
New Revision: 119750

URL: http://llvm.org/viewvc/llvm-project?rev=119750&view=rev
Log:
Fixed the logic in IRForTarget that recognizes
externally-defined variables to match up with
the code in ClangASTSource that produces them.

Modified:
    lldb/trunk/source/Expression/IRForTarget.cpp

Modified: lldb/trunk/source/Expression/IRForTarget.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/IRForTarget.cpp?rev=119750&r1=119749&r2=119750&view=diff
==============================================================================
--- lldb/trunk/source/Expression/IRForTarget.cpp (original)
+++ lldb/trunk/source/Expression/IRForTarget.cpp Thu Nov 18 16:21:58 2010
@@ -362,9 +362,7 @@
                                              CFSCWB_arguments.end(),
                                              "CFStringCreateWithBytes",
                                              FirstEntryInstruction);
-    
-    Constant *initializer = NSStr->getInitializer();
-        
+            
     if (!UnfoldConstant(NSStr, CFSCWB_call, FirstEntryInstruction))
     {
         if (log)
@@ -1089,11 +1087,13 @@
 IRForTarget::resolveExternals(Module &M,
                               Function &F)
 {
+    lldb::LogSP log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_EXPRESSIONS));
+    
     for (Module::global_iterator global = M.global_begin(), end = M.global_end();
          global != end;
          ++global)
     {
-        if ((*global).hasExternalLinkage() &&
+        if (DeclForGlobalValue(M, global) &&
             !MaybeHandleVariable (M, global))
             return false;
     }