[Lldb-commits] [lldb] r116583 - /lldb/trunk/test/lldbtest.py

Johnny Chen johnny.chen at apple.com
Fri Oct 15 09:22:10 PDT 2010


Author: johnny
Date: Fri Oct 15 11:22:10 2010
New Revision: 116583

URL: http://llvm.org/viewvc/llvm-project?rev=116583&view=rev
Log:
Add more comments.

Modified:
    lldb/trunk/test/lldbtest.py

Modified: lldb/trunk/test/lldbtest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/lldbtest.py?rev=116583&r1=116582&r2=116583&view=diff
==============================================================================
--- lldb/trunk/test/lldbtest.py (original)
+++ lldb/trunk/test/lldbtest.py Fri Oct 15 11:22:10 2010
@@ -411,7 +411,9 @@
         self.old_stderr = sys.stderr
         sys.stderr = self.session
 
-        # Optimistically set self.failed to False initially.
+        # Optimistically set self.__failed__ to False initially.  If the test
+        # failed, the session info (self.session) is then dumped into a session
+        # specific file for diagnosis.
         self.__failed__ = False
 
     def setTearDownCleanup(self, dictionary=None):
@@ -422,7 +424,8 @@
         """Callback invoked when we (the test case instance) failed."""
         self.__failed__ = True
         with recording(self, False) as sbuf:
-            # False because there's no need to write "FAIL" to the stderr again.
+            # False because there's no need to write "FAIL" to the stderr twice.
+            # Once by the Python unittest framework, and a second time by us.
             print >> sbuf, "FAIL"
 
     def dumpSessionInfo(self):





More information about the lldb-commits mailing list