[Lldb-commits] [lldb] r114328 - in /lldb/trunk: source/Core/Debugger.cpp test/settings/TestSettings.py

[Johnny Chen]

Author: johnny
Date: Mon Sep 20 11:36:43 2010
New Revision: 114328

URL: http://llvm.org/viewvc/llvm-project?rev=114328&view=rev
Log:
Fixed lldb 'settings set term-widt 70' command not working.

rdar://problem/8449849

Modified:
    lldb/trunk/source/Core/Debugger.cpp
    lldb/trunk/test/settings/TestSettings.py

Modified: lldb/trunk/source/Core/Debugger.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/Debugger.cpp?rev=114328&r1=114327&r2=114328&view=diff
==============================================================================
--- lldb/trunk/source/Core/Debugger.cpp (original)
+++ lldb/trunk/source/Core/Debugger.cpp Mon Sep 20 11:36:43 2010
@@ -1311,7 +1311,7 @@
         char *end = NULL;
         const uint32_t width = ::strtoul (value, &end, 0);
         
-        if (end && end == '\0')
+        if (end && end[0] == '\0')
         {
             if (width >= 10 || width <= 1024)
                 valid = true;

Modified: lldb/trunk/test/settings/TestSettings.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/settings/TestSettings.py?rev=114328&r1=114327&r2=114328&view=diff
==============================================================================
--- lldb/trunk/test/settings/TestSettings.py (original)
+++ lldb/trunk/test/settings/TestSettings.py Mon Sep 20 11:36:43 2010
@@ -30,9 +30,6 @@
         self.expect("settings show",
             substrs = ["prompt (string) = 'lldb2'"])
 
-    @unittest2.expectedFailure
-    # rdar://problem/8449849
-    # settings test case failure (probably after r114252)
     def test_set_term_width(self):
         """Test that 'set term-width' actually changes the term-width."""