[Lldb-commits] [lldb] r113655 - /lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

[Jim Ingham]

Author: jingham
Date: Fri Sep 10 18:02:28 2010
New Revision: 113655

URL: http://llvm.org/viewvc/llvm-project?rev=113655&view=rev
Log:
Always look up the symbols with FindSymbolByID since we are minimizing the symbol list.

Modified:
    lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

Modified: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp?rev=113655&r1=113654&r2=113655&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp Fri Sep 10 18:02:28 2010
@@ -1091,7 +1091,6 @@
                             }                            
                         }
                     }
-
                     if (add_nlist)
                     {
                         bool symbol_name_is_mangled = false;
@@ -1104,7 +1103,6 @@
 
                         if (symbol_name)
                             sym[sym_idx].GetMangled().SetValue(symbol_name, symbol_name_is_mangled);
-
                         if (type == eSymbolTypeCode)
                         {
                             // See if we can find a N_FUN entry for any code symbols.
@@ -1147,7 +1145,6 @@
                                 }
                             }
                         }
-
                         if (symbol_section != NULL)
                             symbol_value -= symbol_section->GetFileAddress();
 
@@ -1166,7 +1163,6 @@
 
                 }
 
-
                 // STAB N_GSYM entries end up having a symbol type eSymbolTypeGlobal and when the symbol value
                 // is zero, the address of the global ends up being in a non-STAB entry. Try and fix up all
                 // such entries by figuring out what the address for the global is by looking up this non-STAB
@@ -1230,11 +1226,7 @@
                                     {
                                         const uint32_t symbol_index = indirect_symbol_index_data.GetU32 (&symbol_stub_offset);
 
-                                        Symbol *stub_symbol;
-                                        if (minimize)
-                                            stub_symbol = symtab->FindSymbolByID (symbol_index);
-                                        else
-                                            stub_symbol = symtab->SymbolAtIndex (symbol_index);
+                                        Symbol *stub_symbol = symtab->FindSymbolByID (symbol_index);
 
                                         assert (stub_symbol);
                                         if (stub_symbol)